bugfix: use strict MariaDB detection in install advisor

[somethingwithproof]

Summary

• switch MariaDB version detection from loose to strict stripos comparison
• avoid ambiguous falsey handling in upgrade advisor engine selection
• add regression test for strict comparison
• update changelog with issue bug: MariaDB detection uses loose stripos comparison in upgrade advisor #270

Fixes #270

Validation

• php -l setup.php
• php -l tests/regression/issue270_mariadb_detection_strict_test.php
• php tests/regression/issue270_mariadb_detection_strict_test.php

[Copilot]

Pull request overview

Updates the Syslog plugin’s install advisor to correctly detect MariaDB by using a strict stripos() comparison, and adds a small regression test plus changelog entry to prevent reintroducing the issue (Fixes #270).

Changes:

• Switch MariaDB detection from loose to strict stripos(...) === false comparison in the install advisor.
• Add a regression test to ensure the strict comparison remains in setup.php.
• Update CHANGELOG.md with the issue reference.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
setup.php	Fixes MariaDB detection comparison used to gate Aria engine selection in the install advisor.
tests/regression/issue270_mariadb_detection_strict_test.php	Adds a regression check to prevent reintroduction of the loose comparison.
CHANGELOG.md	Documents the fix for issue #270.

[Copilot]

syslog_install_advisor() queries the database version using db_fetch_row(), which uses the main Cacti DB connection. When Syslog is configured to use a dedicated DB/server ($use_cacti_db = false), this can mis-detect MariaDB vs MySQL and incorrectly enable/disable the Aria engine option. Use syslog_db_fetch_row() (after syslog_connect()) so the version check runs against the Syslog DB connection.

Suggested change

	$database = db_fetch_row('SHOW GLOBAL VARIABLES LIKE "version"');
	syslog_connect();
	$database = syslog_db_fetch_row('SHOW GLOBAL VARIABLES LIKE "version"');

[somethingwithproof]

Fixed -- using syslog_db_fetch_row() now.

[Copilot]

Spelling: the comment says "storage enging" but should be "storage engine".

Suggested change

	/* remove Aria as a storage enging if this is mysql */
	/* remove Aria as a storage engine if this is mysql */

[somethingwithproof]

Fixed.

[Copilot]

This regression test is very brittle because it relies on exact substring matches of the source code (including spacing/quoting). A harmless reformat (or switching to syslog_db_fetch_row() while keeping the strict comparison) could make the test fail even though the behavior is correct. Consider using a regex match that ignores whitespace and accepts equivalent strict comparisons, or directly exercising the MariaDB-detection logic via a callable function if possible.

Suggested change

	$legacy = "stripos(\$database['Value'], 'mariadb') == false";
	$fixed = "stripos(\$database['Value'], 'mariadb') === false";
	if (strpos($setup, $legacy) !== false) {
	fwrite(STDERR, "Legacy loose MariaDB stripos comparison is still present.\n");
	exit(1);
	}
	if (strpos($setup, $fixed) === false) {
	$legacyPattern = '/stripos\s*\(\s*\$database\s*\[\s*[\'"]Value[\'"]\s*\]\s*,\s*[\'"]mariadb[\'"]\s*\)\s*==\s*false/';
	$fixedPattern = '/stripos\s*\(\s*\$database\s*\[\s*[\'"]Value[\'"]\s*\]\s*,\s*[\'"]mariadb[\'"]\s*\)\s*===\s*false/';
	if (preg_match($legacyPattern, $setup)) {
	fwrite(STDERR, "Legacy loose MariaDB stripos comparison is still present.\n");
	exit(1);
	}
	if (!preg_match($fixedPattern, $setup)) {

[somethingwithproof]

Fixed -- using preg_match() patterns now.

[somethingwithproof]

Fixed in e913ca3 -- now uses syslog_db_fetch_row() so the version check runs against the Syslog DB connection. The spelling was already correct in this branch.