Open
Conversation
Charlie-83
force-pushed
the
stl_codec_binary
branch
3 times, most recently
from
cd5a346 to
a89ee51
Compare
Member
|
@Charlie-83 This test has a method of checking binary file content, in case it's relevant here. https://github.com/CadQuery/cq-cli/blob/main/tests/test_glb_codec.py#L46 |
Author
|
@jmwright Yeah, I did a very similar thing here. Just checking that the first 5 bytes aren't "solid" which would mean it was an ASCII stl. Wikipedia says that the binary format should never start with "solid". Of course, the binary file could just be a load of nonsense. But, I'm guessing that actually parsing the contents to check it's cube is overkill. I could check that the number of triangles is correct or something since that's near the start of the file. |
Charlie-83
force-pushed
the
stl_codec_binary
branch
from
a89ee51 to
7f11181
Compare
Member
|
@Charlie-83 Is this ready for review? |
Author
|
@jmwright Yes, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #29
I have added a
binaryoption to thestlcodec. This should beTrueorFalseDefault encoding is still ASCII for reasons discussed in the issue.
I have added a relevant test.