Fix FDeckViewer section dropdown#9791
Open
MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
Open
Fix FDeckViewer section dropdown#9791MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
Conversation
Replace the "Change Section" button with ItemManager's built-in cbxSection dropdown. Move dropdown population to after cardManager.setup() so initialize() doesn't reset visibility to false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MostCromulent
changed the title
Jetz72
added
Desktop
Deck Editor
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
seems like you should remove duplicating the section name via |
Match deck editor pattern: caption shows just the deck name with a trailing dash, and the dropdown beside it shows the current section. Removes the now-redundant updateCaption() method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
This has been updated to match the pattern in the Deck Editor view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'View Deck' window currently uses a different method of swapping between deck zones compared to the 'Deck Editor' window, for unclear reasons, even though the two are otherwise visually almost identical.
This PR makes the 'View Deck' window use the same dropdown menu as the 'Deck Editor' window, while also preserving the pre-existing 'Change Section' button. Users can either select a section from the dropdown or click the button to cycle through sections.
Summary
ItemManager's built-incbxSectiondropdown, matching the deck editor UITest plan
🤖 Generated with Claude Code