Add Host/Join landing page to online lobby#9899
Add Host/Join landing page to online lobby#9899MostCromulent wants to merge 3 commits intoCard-Forge:masterfrom
Conversation
Replace the single lobby entry point with dedicated Host and Join buttons on both desktop and mobile. Desktop gets an info panel with warning text and a link to the Network Play guide. Mobile uses the preferred-screen pattern for navigation. NetConnectUtil is refactored to separate host setup (ensurePlayerName) from join setup (getJoinServerUrl). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirror the desktop landing page on mobile: show warning text, guide link, and separate Host/Join buttons before any connection is made. Previously, tapping "Play Online" immediately started hosting with no choice, and switching to Join skipped the IP address dialog. - Replace Host/Join menu entries with single Lobby entry in OnlineMenu - Add landing page components to OnlineLobbyScreen (title, warning, guide link, Host/Join buttons) with proper show/hide on connect - Replace desktop JEditorPane hyperlink with FLabel for single-click - Add setLobbyControlsVisible() to LobbyScreen for landing/lobby toggle Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tool4ever
left a comment
tool4ever
left a comment
There was a problem hiding this comment.
hmn, not sure I see the benefit of so much extra code for essentially adding another button click into the workflow 🤷♂️
but maybe another Dev does, so I'll try to sit this one out in favor of some time for eventually reaching delta sync in my backlog 😅
|
No problem. Understand if devs think this is unnecessary - basic intention was 1) get the network configuration guide in front of users at an early stage and b) the current "leave IP address blank to host server, enter IP address to join server" isn't the most intuitive at a glance. (Admittedly people get over this, but I thought may as well try and reduce friction). (Also I don't think this adds to number of UI interactions to enter game because currently you go Online menu > Start Server > IP address screen, whereas this cuts out the Start Server interaction by putting Host/Join straight in the Online menu.) |
|
I'm in favor of it. Combining joining the join server and host server into one UI and code pipeline contingent on leaving a textbox empty made was kind of a janky design. |
4 participants
Replaces the current "Start Server" entry point on both desktop and mobile with a consistent landing page with Host Game / Join Game buttons, warning about bugs, and link to network play wiki page.
Host game goes immediately to lobby screen with Server URL popup, Join game prompts for server IP address and port.