Build fails on lint error due to okio dep#1
Open
virtualandy wants to merge 1 commit intoCasterIO:masterfrom
Open
Build fails on lint error due to okio dep#1virtualandy wants to merge 1 commit intoCasterIO:masterfrom
virtualandy wants to merge 1 commit intoCasterIO:masterfrom
Conversation
`./gradlew build` will fail due to a lint error caused by the inclusion of OkHttp/Okio. The error is something like: ``` Invalid package reference in library; not included in Android: java.nio.file. Referenced from okio.Okio. ``` [Issue in the Okio repo documenting this](square/okio#58) along with steps to lower the level of the flag to a "warning", which is what I've done here. Granted, that affects the entire build, not just the one package. [Here's a similar proposed fix for a similar lint error](http://stackoverflow.com/questions/21827004/gradle-dagger-lint-ignore-by-package) via StackOverflow. This should allow someone to clone/download the repo, run `./gradlew build` and have it succeed. I've tested locally and it seems good.
Author
|
Thanks for these examples, just noticed this error as I went to pull down the deps and build it yesterday. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Changes "InvalidPackage" lint errors to a warning so that the build can proceed. This should allow someone to clone/download the repo, run
./gradlew buildand have it succeed. I've tested locally and it seems good.How should this be manually tested?
Clone the repo, run
./gradlew build.Any background context you want to provide?
./gradlew buildwill fail due to a lint error caused by the inclusion of OkHttp/Okio. The error is something like:Issue in the Okio repo documenting this along with steps to lower the level of the flag to a "warning", which is what I've done here.
Granted, that affects the entire build, not just the one package. Here's a similar proposed fix for a similar lint error via StackOverflow.
What are the relevant issues?
square/okio#58