[ENG-8233] Do not show link addons with no targetUrl#2585
Open
adlius wants to merge 2 commits intoCenterForOpenScience:feature/verified-resource-linkingfrom
Open
[ENG-8233] Do not show link addons with no targetUrl#2585adlius wants to merge 2 commits intoCenterForOpenScience:feature/verified-resource-linkingfrom
adlius wants to merge 2 commits intoCenterForOpenScience:feature/verified-resource-linkingfrom
Conversation
cslzchen
requested changes
Jun 18, 2025
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Verified locally that not fully configured linked services do not show up.
However, this seems to partially break @opaduchak 's fix for #2582. This is for a newly created project without any linked service ever configured.
Before merging this PR locally
After merge
Collaborator
|
fyi, alternative approach in #2588 |
Collaborator
|
Note: will be replaced by #2588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Summary of Changes
Screenshot(s)
Side Effects
QA Notes