[ENG-5675] Phase X: add and apply (black+isort|ruff)#10703
Open
ly-mariia wants to merge 18 commits intoCenterForOpenScience:developfrom
Open
[ENG-5675] Phase X: add and apply (black+isort|ruff)#10703ly-mariia wants to merge 18 commits intoCenterForOpenScience:developfrom
ly-mariia wants to merge 18 commits intoCenterForOpenScience:developfrom
Conversation
Contributor
|
@ly-mariia It looks like this was a reference PR that got used in the ticket, can it be closed now? |
Contributor
@Johnetordoff I think this question is more towards @felliott or @opaduchak |
Member
|
Let's leave it open for a bit. We'll be revisiting this soon in an upcoming maintenance project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Inserting the lining tool into the project;
Changes
Added and applied ruff, may need to make changes in the future as ruff improves;
pre-commit install;QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-5675