[Feature] Adding indication for comments on projects#11114
Open
MackenzieMurphy wants to merge 10 commits intoCenterForOpenScience:developfrom
Open
[Feature] Adding indication for comments on projects#11114MackenzieMurphy wants to merge 10 commits intoCenterForOpenScience:developfrom
MackenzieMurphy wants to merge 10 commits intoCenterForOpenScience:developfrom
Conversation
…for a given node/page
…rns count of all comments
…urn total number of comments
…ack of the number of comments
…o hasComments, it will change the icon color if there are comments
…rue, will change the comment icon to blue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Responding to feature request #9681. On project pages, comments are only indicated to contributors or group members and only when they are unread. Often, the only way to know if a project has comments is to open the comment panel. This PR adds an indication of comments that is accessible to all users.
Changes
Checks if there are comments on a page regardless of who the user is. The comment icon will now be black if there are no comments, and will turn blue (which is what the current icon defaults to) if there are comments. This does not track read status, it only indicates if a project has comments.
QA Notes
While the project compiles correctly on my machine, and I don't foresee any issues, there always seems to be risk of compilation issues. Tests were written to ensure that the code worked.
Documentation
Documentation won't need to be updated.
Side Effects
There should not be any side effects.
Ticket
N/A