[ENG-10238] Allow next_url to contain local url of Angular#11580
Open
ihorsokhanexoft wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
Open
[ENG-10238] Allow next_url to contain local url of Angular#11580ihorsokhanexoft wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
ihorsokhanexoft wants to merge 3 commits intoCenterForOpenScience:feature/pbs-26-2from
Conversation
ihorsokhanexoft
force-pushed
the
fix/ENG-10238
branch
from
994b949 to
cb0e94c
Compare
ihorsokhanexoft
changed the title
ihorsokhanexoft
force-pushed
the
fix/ENG-10238
branch
from
5b1ef04 to
5aeb6e4
Compare
cslzchen
requested changes
Feb 12, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Looks good overall, let's create unit tests as well in addition to my comments.
framework/auth/views.py
Outdated
| from osf import features | ||
|
|
||
|
|
||
| LOCAL_ANGULAR_URL = 'localhost:4200' |
Collaborator
There was a problem hiding this comment.
This may be present in settings, if not let's add it to defualts.py
cslzchen
approved these changes
Feb 13, 2026
Collaborator
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
⭐
In addition, re-target the PR to our feature branch.
Comment on lines
+1212
to
+1213
| if settings.LOCAL_ANGULAR_URL in next_url and settings.DEBUG_MODE: | ||
| return True |
Collaborator
There was a problem hiding this comment.
Let's move this before the comment + putting an extra comment for what this new check is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-10238?atlOrigin=eyJpIjoiZDQ2NTcwZmU1NjE5NGNlYmIyZGYzYWQ3MzQ3NzY0MGMiLCJwIjoiaiJ9
Purpose
CAS should redirect to the new UI locally
Changes
Updated next_url