[ENG-10256] 2.1.9 BE: Fix permission issue where users without permission to an object can access the metadata#11588
Open
mkovalua wants to merge 2 commits intoCenterForOpenScience:feature/fair-signpostingfrom
Conversation
…access the metadata (add decorator is_contributor_or_public_resource)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Purpose
Currently a private project’s metadata can be accessed via the URL osf.io/metadata/<project_guid>/?format=xyz
Expected behavior:
This URL should return a 403 status code and an appropriate error message and not allow users without proper permissions to download the metadata
Changes
implement
is_contributor_or_public_resource(to be it reusable for other calls if needed in future) where is checking if resource is public or auth user is a contributor96b6-b807-4ade-89d1-3e4ba47b8e95.mp4
Side Effects
QE Notes
CE Notes
Documentation