You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the model registration logic to use Python's built-in cls.__name__ instead of a custom cls.NAME attribute when checking and storing class references in _MODEL_REGISTRY.
🔍 Reason for the change:
Using cls.__name__ is more robust and Pythonic—it ensures every class is uniquely identified by its actual class name without relying on the presence or consistency of a manually defined NAME attribute.
Prevents potential issues where cls.NAME may be missing, misdefined, or inconsistent across subclasses.
This should make subclass registration safer and eliminate silent bugs due to missing or duplicate NAME attributes.
Can you tell me why we need this name in the first place? It is saved to a _MODEL_REGISTRY, and then? Is this registry ever used?
The model registry is used to prevent duplicate subclasses extending ChebaiBaseNet—whether they’re defined in the same repo or in an external package like chebai-graph that builds on top of chebai.
Previously, this check relied on each subclass having an explicit NAME attribute, but this PR replaces that with cls.__name__ to make it safer and less error-prone.
Whenever a new subclass is created by extending ChebaiBaseNet, it gets registered in _MODEL_REGISTRY, so yes, the registry is actively used to ensure unique model definitions and avoid silent conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the model registration logic to use Python's built-in
cls.__name__instead of a customcls.NAMEattribute when checking and storing class references in_MODEL_REGISTRY.🔍 Reason for the change:
cls.__name__is more robust and Pythonic—it ensures every class is uniquely identified by its actual class name without relying on the presence or consistency of a manually definedNAMEattribute.cls.NAMEmay be missing, misdefined, or inconsistent across subclasses.This should make subclass registration safer and eliminate silent bugs due to missing or duplicate
NAMEattributes.