Split ratio and inconsistency removal for ensemble#102
Conversation
|
Before this PR, with the default values,
After this PR, with the new default values,
Shouldn’t we adjust the new default values to maintain the same data distribution as before the change? |
|
Well, changing the default values kind of was my intention. I don't think there has ever been an actual reason for the validation set being 15% of 15%. I can't think of a scenario where it is important to have the same split sizes but where you are not re-using the actual splits. |
|
The unit-test failing issue originates from this PR, which was merged into |
|
Thanks, that is my bad. Somehow I missed that the tests were failing for this PR. |
To use the chebai-models for the chebifier-ensemble, I have made some minor changes: