BCE Loss unable to locate processed files #141
Merged
sfluegel05 merged 3 commits intodevfrom Jan 19, 2026
Merged
Conversation
Collaborator
|
Thanks for fixing this. I came to the same conclusion that the handling is inconsistent here. |
bdb7be7 to
89cb005
Compare
Collaborator
|
Great. Since Tim confirmed that it solves his problems as well, we can merge this PR. |
aditya0by0
added a commit
that referenced
this pull request
Jan 22, 2026
commit efac8aa Merge: 0a66ef4 2ead405 Author: Simon Flügel <43573433+sfluegel05@users.noreply.github.com> Date: Thu Jan 22 16:40:22 2026 +0100 Merge pull request #138 from ChEB-AI/fix/read_data Raise error for invalid smiles and return None commit 2ead405 Author: aditya0by0 <aditya0by0@gmail.com> Date: Thu Jan 22 16:34:51 2026 +0100 avoid repeatition of smiles-mol conv commit 0a66ef4 Merge: b32e6c5 203b2b3 Author: Simon Flügel <43573433+sfluegel05@users.noreply.github.com> Date: Thu Jan 22 09:43:01 2026 +0100 Merge pull request #143 from schnamo/dev tidy up config files for loss, fix missing labels issue, etc commit 203b2b3 Merge: f034269 b32e6c5 Author: Charlotte Tumescheit <18518966+schnamo@users.noreply.github.com> Date: Tue Jan 20 13:18:09 2026 +0100 Merge branch 'ChEB-AI:dev' into dev commit f034269 Author: schnamo <ch.tumescheit@gmail.com> Date: Tue Jan 20 13:05:33 2026 +0100 tidy up config files for loss, fix missing labels issue, fix a number of other small issues commit b32e6c5 Merge: c9c08dc a5ea56a Author: Simon Flügel <43573433+sfluegel05@users.noreply.github.com> Date: Mon Jan 19 10:35:01 2026 +0100 Merge pull request #141 from ChEB-AI/fix/file_not_found_for_loss BCE Loss unable to locate processed files commit a5ea56a Author: aditya0by0 <aditya0by0@gmail.com> Date: Thu Jan 15 15:54:15 2026 +0100 docstring commit 89cb005 Author: aditya0by0 <aditya0by0@gmail.com> Date: Fri Jan 9 16:21:26 2026 +0100 pre-commit format commit 0094e6c Author: aditya0by0 <aditya0by0@gmail.com> Date: Fri Jan 9 16:06:18 2026 +0100 File not found error for loss commit 9052aca Author: aditya0by0 <aditya0by0@gmail.com> Date: Thu Dec 18 15:14:24 2025 +0100 Update error msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error: BCE loss unable to locate the
data.ptfileContext
In #89 (comment), it was agreed to introduce a new method
load_processed_data_from_filethat accepts only a filename as input and loads the corresponding file from theprocesseddirectory.However, this change was missed in #92. As a result, the current implementation of
load_processed_data_from_filerequires the entire file path to be passed in order to load the file. While most of the codebase was updated to use this method (by passing the full path), the loss logic was not updated, leading to inconsistent behavior.As the method name suggests, users should only be required to provide the filename. The method itself should be responsible for constructing the full file path by resolving it relative to the
processeddirectory.