You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although I am in general for not changing the formatting too often (as it generates huge diffs, which is the opposite of why we are using formatters in the first place), this change makes sense as it simplifies the workflow considerably.
I added an explanation of how to use pre-commit to the README and removed black and isort from the requirements.
Although I am in general for not changing the formatting too often (as it generates huge diffs, which is the opposite of why we are using formatters in the first place), this change makes sense as it simplifies the workflow considerably.
I added an explanation of how to use pre-commit to the README and removed black and isort from the requirements.
Thanks for the update!
Two more advantages of this change:
We no longer need to keep the formatter versions in sync between GitHub Actions and pre-commit.yaml, avoiding potential version mismatches.
Switching to ruff makes both the workflow and formatting faster, since it’s built in Rust and extremely fast compared to other tools (https://docs.astral.sh/ruff/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruff alone acts are formatter, linter, sorts imports, formats jupyter notebooks. Internally uses black formatting rules.
Hence black is not needed as there is some conflict between black and ruff on some formatting rules.