feat: [E2E] Layers 4/5/6 — System, DSL, and Presets#193
Merged
dhyaniarun1993 merged 33 commits intomainfrom Apr 14, 2026
Merged
feat: [E2E] Layers 4/5/6 — System, DSL, and Presets#193dhyaniarun1993 merged 33 commits intomainfrom
dhyaniarun1993 merged 33 commits intomainfrom
Conversation
- Add `e2e-deploy` named volume to bootstrap container so the manifest survives until tests read it - Write `/tmp/e2e-deploy.json` in docker-bootstrap.sh with contract addresses and issuer party IDs - Add E2E test architecture design doc
…file targets (#178) - Add tests/e2e/devstack/stack/interfaces.go: Anvil, Canton, APIServer, Relayer, Indexer, Postgres interfaces (build tag: e2e) - Add tests/e2e/devstack/stack/types.go: ServiceManifest, Account, AnvilAccount0/1, all request/response/row types, indexer page types - Add tests/e2e/docker-compose.e2e.yaml: thin include wrapper over root docker-compose.yaml; single entry point for E2E test runs - Extend Makefile with test-e2e, test-e2e-api, test-e2e-bridge, test-e2e-indexer targets (stub: "not yet implemented")
Implements issue #181: wires all shims into a composed System, adds high-level DSL operations (RegisterUser, Deposit, ERC20Balance, WaitFor*), and provides DoMain/NewFullStack entry points for test packages.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new E2E testing framework for the devstack, providing a DSL for high-level test operations and a system abstraction to manage service shims. The review feedback highlights a critical bug where balance amounts are compared lexicographically and suggests refactoring resource management by removing testing.T dependencies in global setup to prevent leaks. Additionally, it recommends implementing signal-aware context handling to ensure the Docker stack is properly torn down during interruptions.
Introduces NewIndexerStack and NewAPIStack preset constructors so that test packages only initialise the shims they actually use. DoMain now stores only the manifest; each New*Stack builds its own system with the correct t.Cleanup lifecycle.
- helpers.go: fix lexicographic string comparison in WaitForCantonBalance; parse amounts as big.Float and compare with Cmp - system.go: remove *testing.T from New/NewAPISystem; add closeFunc field and Close() method on System and APISystem for explicit resource management - presets.go: use signal.NotifyContext for SIGINT/SIGTERM handling in DoMain; Stop with fresh context to avoid cancellation race; register t.Cleanup for Close() in NewFullStack and NewAPIStack
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request establishes an E2E test framework for the devstack, providing a DSL for test operations, Docker-based service discovery, and specialized stack presets. The review identifies opportunities to reduce code duplication by centralizing the signEIP191 utility and refactoring shared shim initialization logic in the system package. Furthermore, the feedback suggests using the Anvil shim's Close method directly for better encapsulation.
salindne
reviewed
Apr 9, 2026
salindne
requested changes
Apr 9, 2026
Contributor
salindne
left a comment
salindne
left a comment
There was a problem hiding this comment.
I think theres something thats a bug, but I may be wrong, left a comment.
dhyaniarun1993
approved these changes
Apr 13, 2026
salindne
reviewed
Apr 13, 2026
salindne
reviewed
Apr 13, 2026
salindne
requested changes
Apr 13, 2026
Contributor
salindne
left a comment
salindne
left a comment
There was a problem hiding this comment.
Couple small things, otherwise looks great
salindne
approved these changes
Apr 13, 2026
salindne
added a commit
that referenced
this pull request
Apr 15, 2026
* feat: [E2E] bootstrap writes deploy manifest for test discovery (#177) - Add `e2e-deploy` named volume to bootstrap container so the manifest survives until tests read it - Write `/tmp/e2e-deploy.json` in docker-bootstrap.sh with contract addresses and issuer party IDs - Add E2E test architecture design doc * feat: [E2E] Layer 1 — stack interfaces, types, compose override, Makefile targets (#178) - Add tests/e2e/devstack/stack/interfaces.go: Anvil, Canton, APIServer, Relayer, Indexer, Postgres interfaces (build tag: e2e) - Add tests/e2e/devstack/stack/types.go: ServiceManifest, Account, AnvilAccount0/1, all request/response/row types, indexer page types - Add tests/e2e/docker-compose.e2e.yaml: thin include wrapper over root docker-compose.yaml; single entry point for E2E test runs - Extend Makefile with test-e2e, test-e2e-api, test-e2e-bridge, test-e2e-indexer targets (stub: "not yet implemented") * used existing types * used existing types * added per db dsn * feat: docker discovry added * feat: [E2E] Layer 2 — shim implementations * resolved gemni comments * removed unused db * feat: [E2E] Layers 4/5/6 — System, DSL, and Presets Implements issue #181: wires all shims into a composed System, adds high-level DSL operations (RegisterUser, Deposit, ERC20Balance, WaitFor*), and provides DoMain/NewFullStack entry points for test packages. * feat: [E2E] add IndexerSystem and APISystem subset views Introduces NewIndexerStack and NewAPIStack preset constructors so that test packages only initialise the shims they actually use. DoMain now stores only the manifest; each New*Stack builds its own system with the correct t.Cleanup lifecycle. * fix: address Gemini PR #193 review comments - helpers.go: fix lexicographic string comparison in WaitForCantonBalance; parse amounts as big.Float and compare with Cmp - system.go: remove *testing.T from New/NewAPISystem; add closeFunc field and Close() method on System and APISystem for explicit resource management - presets.go: use signal.NotifyContext for SIGINT/SIGTERM handling in DoMain; Stop with fresh context to avoid cancellation race; register t.Cleanup for Close() in NewFullStack and NewAPIStack * lint fixed * api server to act as ethclient * fix lint * optimized * optimized implementation * lint fixed * reolved gemini comments * e2e test for middleware server * resolved comments * feat: [E2E] Layer 2 — token client, error-safe NewCanton, HTTPError, util refactor * feat: [E2E] Layers 4/5/6 — Canton integration, token ops, WaitForAPIBalance, TestAccounts * added missing tests * addressed gemini comment * party generation on registration * resolve comment --------- Co-authored-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
salindne
pushed a commit
that referenced
this pull request
Apr 16, 2026
* feat: [E2E] bootstrap writes deploy manifest for test discovery (#177) - Add `e2e-deploy` named volume to bootstrap container so the manifest survives until tests read it - Write `/tmp/e2e-deploy.json` in docker-bootstrap.sh with contract addresses and issuer party IDs - Add E2E test architecture design doc * feat: [E2E] Layer 1 — stack interfaces, types, compose override, Makefile targets (#178) - Add tests/e2e/devstack/stack/interfaces.go: Anvil, Canton, APIServer, Relayer, Indexer, Postgres interfaces (build tag: e2e) - Add tests/e2e/devstack/stack/types.go: ServiceManifest, Account, AnvilAccount0/1, all request/response/row types, indexer page types - Add tests/e2e/docker-compose.e2e.yaml: thin include wrapper over root docker-compose.yaml; single entry point for E2E test runs - Extend Makefile with test-e2e, test-e2e-api, test-e2e-bridge, test-e2e-indexer targets (stub: "not yet implemented") * used existing types * used existing types * added per db dsn * feat: docker discovry added * feat: [E2E] Layer 2 — shim implementations * resolved gemni comments * removed unused db * feat: [E2E] Layers 4/5/6 — System, DSL, and Presets Implements issue #181: wires all shims into a composed System, adds high-level DSL operations (RegisterUser, Deposit, ERC20Balance, WaitFor*), and provides DoMain/NewFullStack entry points for test packages. * feat: [E2E] add IndexerSystem and APISystem subset views Introduces NewIndexerStack and NewAPIStack preset constructors so that test packages only initialise the shims they actually use. DoMain now stores only the manifest; each New*Stack builds its own system with the correct t.Cleanup lifecycle. * fix: address Gemini PR #193 review comments - helpers.go: fix lexicographic string comparison in WaitForCantonBalance; parse amounts as big.Float and compare with Cmp - system.go: remove *testing.T from New/NewAPISystem; add closeFunc field and Close() method on System and APISystem for explicit resource management - presets.go: use signal.NotifyContext for SIGINT/SIGTERM handling in DoMain; Stop with fresh context to avoid cancellation race; register t.Cleanup for Close() in NewFullStack and NewAPIStack * lint fixed * api server to act as ethclient * fix lint * optimized * optimized implementation * lint fixed * reolved gemini comments * e2e test for middleware server * resolved comments * feat: [E2E] Layer 2 — token client, error-safe NewCanton, HTTPError, util refactor * feat: [E2E] Layers 4/5/6 — Canton integration, token ops, WaitForAPIBalance, TestAccounts * added missing tests * addressed gemini comment * added test for relayer * optimized tests * resolved gemini comments * resolve comment * tk -> demoTk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system/system.go(Layer 4): composes all shims into a singleSystemstruct wired viaNew(ctx, t, manifest)dsl/dsl.go+dsl/helpers.go(Layer 5): high-level ops (RegisterUser,Deposit,ERC20Balance) and polling helpers (WaitForRelayerReady,WaitForCantonBalance,WaitForRelayerTransfer,WaitForIndexerEvent)presets/options.go+presets/presets.go(Layer 6):DoMain(m, opts...)forTestMainandNewFullStack(t)for per-test system accessTest plan
go build -tags e2e ./tests/e2e/...compiles cleanlyDoMainstarts compose stack, resolves manifest, initialises system, runsm.Run(), tears down on exitNewFullStackreturns the shared system; fails immediately ifDoMainwas not called firstCloses #181