Skip to content

fix(ci): rpc check failure#6851

Merged
hanabi1224 merged 6 commits intomainfrom
hm/fix-rpc-ci
Apr 6, 2026
Merged

fix(ci): rpc check failure#6851
hanabi1224 merged 6 commits intomainfrom
hm/fix-rpc-ci

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Apr 3, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Standardized Lotus container image to stable v1.35.1 across environments.
  • Improvements
    • Increased API gateway lookback limit to improve stability when awaiting chain state.
    • Added startup version checks for node components to ensure expected runtimes.
    • Introduced a via-gateway service with health checks to improve connectivity and reduce transient failures.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Apr 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

Walkthrough

Replaced release-candidate Lotus image tags with final v1.35.1 tags across env files and added a dedicated lotus-via-gateway service and port. docker-compose for API-compare now runs version checks, increases gateway lookback, adds a lotus-via-gateway healthcheck, and routes websocket traffic through the via-gateway.

Changes

Cohort / File(s) Summary
Env: Lotus image tags
scripts/tests/api_compare/.env, scripts/devnet/.env, scripts/tests/bootstrapper/.env, scripts/tests/snapshot_parity/.env
Removed -rc1 from LOTUS_IMAGE tags (e.g., filecoin/lotus-all-in-one:v1.35.1-rc1-...filecoin/lotus-all-in-one:v1.35.1-...); added LOTUS_VIA_GATEWAY_RPC_PORT=4568 in scripts/tests/api_compare/.env.
API-compare docker-compose
scripts/tests/api_compare/docker-compose.yml
Added lotus-via-gateway service with healthcheck and exposes ${LOTUS_VIA_GATEWAY_RPC_PORT}; forest-via-gateway and lotus services run --version before starting; increased --api-wait-lookback-limit on gateway from 200020000; api-compare-gateway now depends on lotus-via-gateway:healthy; Lotus websocket endpoint switched to via-gateway address.

Sequence Diagram(s)

sequenceDiagram
  participant APICompare as API-compare-gateway
  participant ViaGateway as lotus-via-gateway
  participant Lotus as lotus
  participant Forest as forest-via-gateway

  APICompare->>ViaGateway: Wait for healthy
  ViaGateway->>ViaGateway: lotus-gateway --version\nlotus-gateway run (listen ${LOTUS_VIA_GATEWAY_RPC_PORT})
  ViaGateway->>Lotus: RPC requests (proxied websocket /dns/lotus-via-gateway/tcp/${LOTUS_VIA_GATEWAY_RPC_PORT}/ws)
  Lotus->>ViaGateway: Respond to proxied RPCs
  Forest->>ViaGateway: Connect to via-gateway websocket (listen ${FOREST_VIA_GATEWAY_RPC_PORT})
  APICompare->>ViaGateway: Forward API-compare websocket traffic
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
  • sudo-shashank
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(ci): rpc check failure' is vague and does not clearly convey what the changes accomplish, using generic terminology without describing the specific modifications. Revise the title to be more specific about the actual changes, such as 'fix(ci): add lotus-via-gateway service for RPC API comparison' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/fix-rpc-ci
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/fix-rpc-ci

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review April 3, 2026 10:03
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 3, 2026 10:03
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team April 3, 2026 10:03
@hanabi1224 hanabi1224 enabled auto-merge April 3, 2026 10:27
@hanabi1224 hanabi1224 disabled auto-merge April 6, 2026 05:27
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
scripts/tests/api_compare/.env (1)

4-4: Optional: Consider key ordering.

The linter suggests ordering keys alphabetically. However, the current grouping by purpose (images → paths → ports → config) may be more maintainable than strict alphabetical order.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@scripts/tests/api_compare/.env` at line 4, The linter flagged key ordering in
the .env (the variable FIL_PROOFS_PARAMETER_CACHE) — fix by either reordering
environment keys alphabetically (move FIL_PROOFS_PARAMETER_CACHE to its
alphabetic position among other .env keys) or preserve the existing logical
grouping and add a linter override/comment for this file to disable the
key-order rule; reference the variable name FIL_PROOFS_PARAMETER_CACHE when
making the change so reviewers can find and verify the adjustment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/tests/api_compare/.env`:
- Line 4: The linter flagged key ordering in the .env (the variable
FIL_PROOFS_PARAMETER_CACHE) — fix by either reordering environment keys
alphabetically (move FIL_PROOFS_PARAMETER_CACHE to its alphabetic position among
other .env keys) or preserve the existing logical grouping and add a linter
override/comment for this file to disable the key-order rule; reference the
variable name FIL_PROOFS_PARAMETER_CACHE when making the change so reviewers can
find and verify the adjustment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 726f636c-713d-48e4-9598-8c602ab4e931

📥 Commits

Reviewing files that changed from the base of the PR and between d19925b and 2653dd9.

📒 Files selected for processing (2)
  • scripts/tests/api_compare/.env
  • scripts/tests/api_compare/docker-compose.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/tests/api_compare/docker-compose.yml

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.94%. Comparing base (45f66c3) to head (2653dd9).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f66c3...2653dd9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanabi1224 hanabi1224 added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit e7c2f0f Apr 6, 2026
38 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-rpc-ci branch April 6, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants