Conversation
WalkthroughReplaced release-candidate Lotus image tags with final v1.35.1 tags across env files and added a dedicated lotus-via-gateway service and port. docker-compose for API-compare now runs version checks, increases gateway lookback, adds a lotus-via-gateway healthcheck, and routes websocket traffic through the via-gateway. Changes
Sequence Diagram(s)sequenceDiagram
participant APICompare as API-compare-gateway
participant ViaGateway as lotus-via-gateway
participant Lotus as lotus
participant Forest as forest-via-gateway
APICompare->>ViaGateway: Wait for healthy
ViaGateway->>ViaGateway: lotus-gateway --version\nlotus-gateway run (listen ${LOTUS_VIA_GATEWAY_RPC_PORT})
ViaGateway->>Lotus: RPC requests (proxied websocket /dns/lotus-via-gateway/tcp/${LOTUS_VIA_GATEWAY_RPC_PORT}/ws)
Lotus->>ViaGateway: Respond to proxied RPCs
Forest->>ViaGateway: Connect to via-gateway websocket (listen ${FOREST_VIA_GATEWAY_RPC_PORT})
APICompare->>ViaGateway: Forward API-compare websocket traffic
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/tests/api_compare/.env (1)
4-4: Optional: Consider key ordering.The linter suggests ordering keys alphabetically. However, the current grouping by purpose (images → paths → ports → config) may be more maintainable than strict alphabetical order.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/tests/api_compare/.env` at line 4, The linter flagged key ordering in the .env (the variable FIL_PROOFS_PARAMETER_CACHE) — fix by either reordering environment keys alphabetically (move FIL_PROOFS_PARAMETER_CACHE to its alphabetic position among other .env keys) or preserve the existing logical grouping and add a linter override/comment for this file to disable the key-order rule; reference the variable name FIL_PROOFS_PARAMETER_CACHE when making the change so reviewers can find and verify the adjustment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scripts/tests/api_compare/.env`:
- Line 4: The linter flagged key ordering in the .env (the variable
FIL_PROOFS_PARAMETER_CACHE) — fix by either reordering environment keys
alphabetically (move FIL_PROOFS_PARAMETER_CACHE to its alphabetic position among
other .env keys) or preserve the existing logical grouping and add a linter
override/comment for this file to disable the key-order rule; reference the
variable name FIL_PROOFS_PARAMETER_CACHE when making the change so reviewers can
find and verify the adjustment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 726f636c-713d-48e4-9598-8c602ab4e931
📒 Files selected for processing (2)
scripts/tests/api_compare/.envscripts/tests/api_compare/docker-compose.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts/tests/api_compare/docker-compose.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit