Skip to content

feat: initial implementation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajtos merged 2 commits into from
Mar 18, 2025
Merged

feat: initial implementation #2

bajtos merged 2 commits into from
Mar 18, 2025

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Mar 17, 2025 •
edited
Loading

The initial version based on the prior work here:

Quoting from README:

import { assertOkResponse } from 'assert-ok-response'

const response = await fetch('https://example.com/not-found')
await assertOkResponse(response)
//
// Throws:
//
//  const err = new Error(`${errorMsg ?? `Cannot fetch ${res.url}`} (${res.status}): ${body}`)
//                ^
//
//  Error: Cannot fetch https://example.com/not-found (404): <!doctype html>
//  [...]
//  at assertOkResponse (file:///Users/bajtos/src/assert-ok-response/index.js:15:15)
//  at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
//  at async file:///Users/bajtos/src/assert-ok-response/x.js:4:1 {
//    statusCode: 404,
//    serverMessage: '<!doctype html>\n' +
//  [...]

Error properties:

  • statusCode (number) - The HTTP status code of the response.
  • serverMessage (string) - The response body returned by the server.

@bajtos
feat: initial implementation
89302e4 
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
bajtos commented Mar 17, 2025
View reviewed changes
@bajtos bajtos merged commit 9810110 into main Mar 18, 2025
4 checks passed
@bajtos bajtos deleted the initial-impl branch March 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliangruber juliangruber juliangruber approved these changes

@pyropy pyropy pyropy approved these changes

+1 more reviewer

@NikolasHaimerl NikolasHaimerl NikolasHaimerl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bajtos @juliangruber @pyropy @NikolasHaimerl