Refactor GraphQL endpoint options for clarity#9425
Open
zambianchi wants to merge 8 commits intoChilliCream:mainfrom
Open
Refactor GraphQL endpoint options for clarity#9425zambianchi wants to merge 8 commits intoChilliCream:mainfrom
zambianchi wants to merge 8 commits intoChilliCream:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation and code examples for NitroAppOptions to align with the breaking changes introduced in Hot Chocolate v16.
With the introduction of new overloads in v16 (such as the distinction between different configuration contexts), the compiler may fail to resolve the correct method.
Key Changes
Explicit Type Declaration: Updated examples to use explicit typing in lambda expressions (e.g., (NitroAppOptions option) => ...) to prevent AmbiguousMatchException or compilation errors.
Property Mapping: Refined the usage of option.Enable and option.ServeMode to reflect the latest recommended defaults for development and testing environments
Before (v15 and below):
After (v16 - Recommended):