Skip to content

Improve performance of result document operations #9462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelstaib wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve performance of result document operations #9462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d144560
Improve performance of result document operations
michaelstaib Mar 27, 2026
bb62d4a
Merge branch 'main' into mst/result-doc
michaelstaib Mar 27, 2026
b36ecd6
Merge branch 'main' into mst/result-doc
michaelstaib Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/HotChocolate/Core/src/Types/Text/Json/ResultDocument.Cursor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,14 @@ public Cursor AddRows(int delta)
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public Cursor WithRow(int row) => From(Chunk, row);

public int Index
{
[MethodImpl(MethodImplOptions.AggressiveInlining)]
get => (Chunk * RowsPerChunk) + Row;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int ToIndex() => (Chunk * RowsPerChunk) + Row;
public int ToIndex() => Index;

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public int ToTotalBytes() => (Chunk * ChunkBytes) + ByteOffset;
Expand Down
14 changes: 14 additions & 0 deletions src/HotChocolate/Core/src/Types/Text/Json/ResultDocument.MetaDb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,20 @@ internal DbRow Get(Cursor cursor)
return MemoryMarshal.Read<DbRow>(span);
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal DbRow GetValue(ref Cursor cursor)
{
var row = Get(cursor);

if (row.TokenType is ElementTokenType.Reference)
{
cursor = Cursor.FromIndex(row.Location);
row = Get(cursor);
}

return row;
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal (Cursor, ElementTokenType) GetStartCursor(Cursor cursor)
{
Expand Down
14 changes: 6 additions & 8 deletions src/HotChocolate/Core/src/Types/Text/Json/ResultDocument.TryGetProperty.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ internal bool TryGetNamedPropertyValue(
{
ObjectDisposedException.ThrowIf(_disposed, this);

(startCursor, var tokenType) = _metaDb.GetStartCursor(startCursor);
CheckExpectedType(ElementTokenType.StartObject, tokenType);
var row = _metaDb.GetValue(ref startCursor);
CheckExpectedType(ElementTokenType.StartObject, row.TokenType);

var numberOfRows = _metaDb.GetNumberOfRows(startCursor);
var numberOfRows = row.NumberOfRows;

// Only one row means it was EndObject.
if (numberOfRows == 1)
Expand All @@ -24,7 +24,6 @@ internal bool TryGetNamedPropertyValue(
return false;
}

var row = _metaDb.Get(startCursor);
if (row.OperationReferenceType is OperationReferenceType.SelectionSet)
{
var selectionSet = _operation.GetSelectionSetById(row.OperationReferenceId);
Expand Down Expand Up @@ -120,10 +119,10 @@ internal bool TryGetNamedPropertyValue(
{
ObjectDisposedException.ThrowIf(_disposed, this);

(startCursor, var tokenType) = _metaDb.GetStartCursor(startCursor);
CheckExpectedType(ElementTokenType.StartObject, tokenType);
var row = _metaDb.GetValue(ref startCursor);
CheckExpectedType(ElementTokenType.StartObject, row.TokenType);

var numberOfRows = _metaDb.GetNumberOfRows(startCursor);
var numberOfRows = row.NumberOfRows;

// Only one row means it was EndObject.
if (numberOfRows == 1)
Expand All @@ -132,7 +131,6 @@ internal bool TryGetNamedPropertyValue(
return false;
}

var row = _metaDb.Get(startCursor);
if (row.OperationReferenceType is OperationReferenceType.SelectionSet)
{
var selectionSet = _operation.GetSelectionSetById(row.OperationReferenceId);
Expand Down
Loading
Loading