Major Overhaul (Java autoprovisionning, in-game config) by AnasDevO · Pull Request #36 · CleanroomMC/CleanroomRelauncher

AnasDevO · 2026-02-21T14:13:44Z

Overview

This PR introduces a major overhaul of the Cleanroom Relauncher's user experience. It transitions the configuration process from a pre-launch GUI to a seamless install process with minimal user interaction.

Changelog

Relauncher can now do autoprovisionning of Java installations with FooJay API. it can be overriden by selecting manual selection.
The settings GUI now has argument checkboxes, to make the process of argument optimisations automated.
Relauncher now has new workflows:
- First time user: Will be prompted with a GUI that has two buttons: Relaunch now, which will auto select latest cleanroom release and J25 - Zulu, and advanced settings, which will give the ability to modify the settings.
- Modpack Maker: upon registering the settings for Automatic Install, the relauncher.json can now be shipped with the pack to automatically trigger autoprovisionning, and requires 0 input from the user.
Instead of always provisionning new java installs, polluting the environnement of the user, Relauncher will first check for java installations that matches targetVersion and targetVendor.
Relauncher can be toggled in game, in both Cleanroom and Forge environnement, directly from an in-game Options menu.

Screenshots

Bronitt · 2026-02-21T14:24:02Z

As both a player and a modpack developer, I’d love to see the targetVendor field support multiple values. Could you please implement this feature?

AnasDevO · 2026-02-21T14:32:51Z

As both a player and a modpack developer, I’d love to see the targetVendor field support multiple values. Could you please implement this feature?

What purpose would this feature serve? only one value should be present imo

Bronitt · 2026-02-21T14:44:22Z

What purpose would this feature serve? only one value should be present imo

I have Adoptium installed, while one player might have Zulu and another GraalVM. As I understand it, if I set the parameter to Adoptium, the Relauncher will download an additional Java version for those other players.

There is almost no difference between these three vendors, so why limit it to just one? I agree that a single value should be used for downloading, but for the local search on the user's device, I’d like to be able to specify multiple options.

AnasDevO · 2026-02-21T14:46:37Z

you can set preferred vendor to Any
it will return true for any vendor

Bronitt · 2026-02-21T14:49:01Z

you can set preferred vendor to Any it will return true for any vendor

Oh, I see. I hadn't looked at the code, so I wasn't aware of that feature.

tttsaurus · 2026-02-21T15:43:49Z

Suggestions

launched with zulu 8 and zulu 25 ingame

Scanning Progress Bar

This progress bar looks relatively smaller than other menus. Could be bigger imo
Download Complete

I got a transient pop up window "Download Complete" after the Java scanning. Is that intended?
This window also popped up for the later launches when the config is generated.
Regardless, the percentage was always 0% and the short lived pop up window feels abruptive.
Ingame Config Window

Maybe it's less intuitive to talk about auto install when the game is launched (config is generated)?

AnasDevO · 2026-02-21T17:07:04Z

This progress bar looks relatively smaller than other menus. Could be bigger imo

You are right, i revamped it.

I got a transient pop up window "Download Complete" after the Java scanning. Is that intended?
This window also popped up for the later launches when the config is generated.
Regardless, the percentage was always 0% and the short lived pop up window feels abruptive.

You are correct, that's the progress bar for downloading libraries, it mistakenly fired even when there's nothing to download. Fixed now.

Maybe it's less intuitive to talk about auto install when the game is launched (config is generated)?

Don't know what else to call it, as this configuration pane is more targetted towards pack devs.

tttsaurus · 2026-02-21T17:21:32Z

Don't know what else to call it, as this configuration pane is more targetted towards pack devs.

Yeah makes sense too. Casual players won't even click that in-game config button I guess.

Also what do you think about "Discard Changes" instead of "Cancel Configuration"?

AnasDevO · 2026-02-21T19:35:43Z

that's a good one, actually.
Will implement that.

jchung01 · 2026-02-21T21:03:27Z

Currently the relauncher seems to re-download Java even if it has already downloaded Java to ~/.cleanroom/java. This can be triggered by deleting relauncher.json or running first-time setup of the relauncher again in another instance.

jchung01 · 2026-02-21T21:05:37Z

+    @Mod.EventHandler
+    public void preInit(FMLPreInitializationEvent event) {
+        MinecraftForge.EVENT_BUS.register(new OptionsMenuHandler());
+        CleanroomRelauncher.LOGGER.info("Pre-Init Event has fired Relauncher");
+    }


Should move this to CleanroomRelauncher, and that file should be marked as @Mod instead, as this one is just an event handler.

Also, should enable use_tags in gradle.properties and use the constants from generated Tags for @Mod values.

Should move this to CleanroomRelauncher, and that file should be marked as @Mod instead, as this one is just an event handler.

I think it might be better to keep it in that file, for readability?

Some of the files are kinda huge already..

It's not about readability, it's about naming. It's not clear that OptionsMenuHandler is a Forge mod entrypoint from the name. Please instead name it CleanroomRelauncherMod, or write a new class with that name which registers OptionsMenuHandler as a supplementary event handler.

AnasDevO · 2026-02-21T21:30:16Z

Currently the relauncher seems to re-download Java even if it has already downloaded Java to ~/.cleanroom/java. This can be triggered by deleting relauncher.json or running first-time setup of the relauncher again in another instance.

yeah, i'm able to reproduce it now...
should probably add a check for that folder.

Rongmario

Merging it first for a beta

AnasDevO added 4 commits February 19, 2026 14:27

Revamp

76ecf50

Finish Relauncher config and edge cases

64c9050

Fix version aware args

b23c223

Fix typo

4e7c9d8

Improve loading GUI

5778d6c

Fix oracle GUI size

a5f18a0

AnasDevO added 2 commits February 21, 2026 19:39

Change Cancel button name to "Discard Changes"

5199768

Add Disclaimer

2bc93c8

jchung01 reviewed Feb 21, 2026

View reviewed changes

AnasDevO added 2 commits February 21, 2026 23:12

Fix Java installs not parsing /home/.cleanroom/java

77c5410

Use Tags

c1fd097

Rongmario approved these changes Mar 20, 2026

View reviewed changes

Rongmario merged commit 3a1ab00 into CleanroomMC:master Mar 20, 2026

Rongmario mentioned this pull request Mar 20, 2026

Add "Download Java" button to dialog & other small changes #35

Closed

Conversation

AnasDevO commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changelog

Screenshots

Uh oh!

Bronitt commented Feb 21, 2026

Uh oh!

AnasDevO commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bronitt commented Feb 21, 2026

Uh oh!

AnasDevO commented Feb 21, 2026

Uh oh!

Bronitt commented Feb 21, 2026

Uh oh!

tttsaurus commented Feb 21, 2026

Suggestions

Uh oh!

AnasDevO commented Feb 21, 2026

Uh oh!

tttsaurus commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AnasDevO commented Feb 21, 2026

Uh oh!

jchung01 commented Feb 21, 2026

Uh oh!

jchung01 Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

jchung01 Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

AnasDevO Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

trustytrojan Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

AnasDevO commented Feb 21, 2026

Uh oh!

Rongmario left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AnasDevO commented Feb 21, 2026 •

edited

Loading

AnasDevO commented Feb 21, 2026 •

edited

Loading

tttsaurus commented Feb 21, 2026 •

edited

Loading