feat(portal-provider): Add portal layer provider#1080
Open
kunalpanchal wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 0902a00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-4c0pg5ax5-clickhouse.vercel.app Built from commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a ClickUI portal provider API for detached panels and other layered surfaces.
PortalProvider,usePortalContainer, anduseResolvedPortalContainercontaineroverridesContext
This supports CUI-179 and avoids product code needing to target Radix internals or inject global z-index CSS for detached panels.
Note
Medium Risk
Touches portal mounting across many overlay components; wrong container choice could affect stacking, focus, or clipping in embedded panels, though behavior is backward-compatible when no provider is used.
Overview
Introduces
PortalProvideranduseResolvedPortalContainerso layered UI can default to a shared DOM mount point instead of only per-component Radix portals.Wrap overlay Select, Popover, Tooltip, Dropdown, AutoComplete, DatePicker, ContextMenu, HoverCard, Dialog, and Flyout so their portal
containercomes from the provider when a content prop does not passcontainerexplicitly; passingcontaineron a component still wins. Tooltip gains acontainerprop on content (types moved toTooltip.types.ts). The public package exportsPortalProvider,usePortalContainer,useResolvedPortalContainer, and related types, with a minor changeset and integration tests for provider placement and override behavior.Reviewed by Cursor Bugbot for commit 0902a00. Bugbot is set up for automated code reviews on this repo. Configure here.