fix: correct Python module naming for tree_sitter_vb_dotnet#6
Open
mishkaechoes wants to merge 1 commit intoCodeAnt-AI:mainfrom
Open
fix: correct Python module naming for tree_sitter_vb_dotnet#6mishkaechoes wants to merge 1 commit intoCodeAnt-AI:mainfrom
mishkaechoes wants to merge 1 commit intoCodeAnt-AI:mainfrom
Conversation
The Python bindings were incorrectly named with a doubled prefix: - `tree_sitter_tree_sitter_vb_dotnet` -> `tree_sitter_vb_dotnet` This caused an ImportError when trying to use the package because the C binding exported `tree_sitter_vb_dotnet` but Python looked for `tree_sitter_tree_sitter_vb_dotnet`. Changes: - Renamed bindings/python/tree_sitter_tree_sitter_vb_dotnet/ to bindings/python/tree_sitter_vb_dotnet/ - Updated binding.c to use correct symbol name - Updated setup.py package references - Fixed pyproject.toml homepage URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python bindings were incorrectly named with a doubled prefix, causing an ImportError when trying to use the package.
Problem
When installing and importing the package:
The C binding exported
tree_sitter_vb_dotnet(matching the grammar name ingrammar.js), but the Python package directory and references usedtree_sitter_tree_sitter_vb_dotnet.Changes
bindings/python/tree_sitter_tree_sitter_vb_dotnet/→bindings/python/tree_sitter_vb_dotnet/binding.cto use the correct symbol namesetup.pypackage referencespyproject.tomlhomepage URLTesting
After the fix:
This enables Python users to properly parse VB.NET code with tree-sitter.