feat: Create automatically a thread on discord when creating a reposi…#66
Draft
vassilidev wants to merge 18 commits intodevelopfrom
Draft
feat: Create automatically a thread on discord when creating a reposi…#66vassilidev wants to merge 18 commits intodevelopfrom
vassilidev wants to merge 18 commits intodevelopfrom
Conversation
…to-discord # Conflicts: # app/Models/Repository.php
mariorocha
reviewed
Apr 21, 2023
| public function execute( | ||
| string $name, | ||
| ChannelType $channelType = ChannelType::TEXT, | ||
| ?string $parentId = null |
There was a problem hiding this comment.
What is your opinion on union types?
I think its more readable and clear using it, like null|string
Collaborator
Author
There was a problem hiding this comment.
for null its ok to use "?"
Collaborator
Author
There was a problem hiding this comment.
string|int|null ok
bcuz ?string|int not readable and may not work
geeksesi
reviewed
May 4, 2023
| { | ||
| try { | ||
| /** @var ChannelData $threadData */ | ||
| $threadData = app(CreateChannel::class)->execute( |
Collaborator
There was a problem hiding this comment.
is it ok to create a forum on discord per repository?!
Collaborator
Author
There was a problem hiding this comment.
Yes ! but we have to re work this pr, lot of change since and i want to make a lot of new thing.
My idea was : One Forum per repo and one thread into the forum per pr
This reverts commit 2f45789.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Create automatically a thread on discord when creating a repository.