Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe#1241
Manchester | 26-ITP-May | Monsur Abdulrahman | Sprint 2 | Wireframe#1241Monsur0001 wants to merge 7 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Monsur0001
added
Needs Review
illicitonion
changed the title
Sambuxc
added
the
Review in progress
| <p class="center">Practicing commits in Git</p> | ||
| </header> | ||
| <main> | ||
| <div class="container"> |
There was a problem hiding this comment.
Is there a semantic tag you could use instead here?
There was a problem hiding this comment.
Thank you so much for your feedback. I have switched back to the "main" semantic tag.
| </main> | ||
| </div> | ||
|
|
||
| <div class="article-row"> |
There was a problem hiding this comment.
Is there a semantic tag you could use instead here?
There was a problem hiding this comment.
Thank you so much for your feedback. I have also switched this back to the "main" semantic tag.
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> |
There was a problem hiding this comment.
Your page head should include a title and description
There was a problem hiding this comment.
Thank you so much for your feedback. I have added the description as suggested.
| margin: 0 auto calc(var(--space) * 4) auto; | ||
| } | ||
| footer { | ||
| position: fixed; |
There was a problem hiding this comment.
Why did you decide to remove the fixed position?
There was a problem hiding this comment.
Thank you so much for your feedback. I noticed that when I leave the fixed position, I realized that my footer aligns back to the left instead of staying at the center. However, after deep research about the issue, I found that adding a width of 100% would easily solve the problem. I have made the correction immediately.
There was a problem hiding this comment.
It looks much better now, however the text becomes unreadable when scrolling at the background shows the page content through it.
Can you think of a way to make sure the text either; does not overlap the page content when scroll, or has an appropriate background color to make the footer text always readable?
There was a problem hiding this comment.
I really do appreciate your feedback. I have fixed the readability issue by adding a white background to the footer. I also added a padding to it to solve the overlapping issue, so the users can actually see the last line of the content.. Thank you so much.
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> |
There was a problem hiding this comment.
How have you linked your html to the style.css file?
There was a problem hiding this comment.
Thank you for your feedback. I have linked my css with this line of code ""
|
I really appreciate your feedback on my pull request. I have made all the suggested corrections and I am looking forward for your further feedback on it. Thank you so much. |
Monsur0001
left a comment
Monsur0001
left a comment
There was a problem hiding this comment.
I have done all the suggested corrections. Thank you so much as I anticipate your further feedback
Sambuxc
added
Reviewed
3 participants
Self checklist
Changelist
Wireframe tasks completed.