London | 26-ITP-May| Mahdi Rafiei | Sprint 1 | Form Controls#1245
Open
mrafeie wants to merge 1 commit into
Open
London | 26-ITP-May| Mahdi Rafiei | Sprint 1 | Form Controls#1245mrafeie wants to merge 1 commit into
mrafeie wants to merge 1 commit into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mrafeie
added
Needs Review
Luro91
added
Review in progress
Luro91
reviewed
May 14, 2026
| <label for="size">T-Shirt Size</label> | ||
|
|
||
| <select id="size" name="size"> | ||
| <option value="">Please choose a size</option> |
There was a problem hiding this comment.
What happens when the user would submit the form with this value?
Comment on lines
+19
to
+24
| type="text" | ||
| id="name" | ||
| name="name" | ||
| required | ||
| pattern=".*\S.*\S.*" | ||
| minlength="2" |
There was a problem hiding this comment.
Its good practice to use indentation on the html attributes to make it more readable. How could you ensure consistent and standard formatting of your code?
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
added the form as described in the task