-
-
Notifications
You must be signed in to change notification settings - Fork 383
Manchester | ITP - Jan - 2026 | Mehroz Munir | Sprint 1 | Wireframe to Web Code #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).
Note: Currently there is no footer on your page.
2
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start, but the main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. To better align with the wireframe, here are a few areas where the layout and appearance could be refined:
- Center the TITLE and the SUBTITLE on the page
- Make the images span the full width of their respective container
Suggestion
After you have made all the changes, try asking AI for possible improvements in terms of semantic, accessibility, typo, and consistency.
It can often help us catch errors, improve consistency, and reinforce best practices.
Your code looks great. If you want to further improve your code, you can try asking AI. When I asked ChatGPT to check for typo and consistency, it gave some good suggestions for possible improvements (minor improvements). |
|
Sorry, I hadn’t fully understood what “fixed footer” meant earlier, but it should now be working correctly. I’ve also made some improvements to the code. Thanks for your patience and for all the helpful feedback. |
|
Changes look good. Well done. |
|
You may want to use |

Self checklist
Changelist
I have followed the wireframe design and the code already given in the wireframe folder to create three sections just like in wireframe. The display style of the main tag was set to grid to create sections. The three sections were created using semantic tag
in HTML and the first child was set the value of span 2 to cover the whole screen just like shown in the wireframe.Placeholder images were changed on the page according to the sections. The footer was overlaying and fixed by removing its fixed position in CSS file.