Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Implement functions and rewrite tests by RomanSanaye · Pull Request #1119 · CodeYourFuture/Module-Structuring-and-Testing-Data

RomanSanaye · 2026-03-01T20:17:17Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Updated getCardValue function to properly validate card ranks using /^[JQK]$/ for face cards instead of /J|Q|K/.
Added Jest tests for edge cases mentioned by the reviewer: "0x02♠", "QQ♠", "2.1♠".
Refactored existing tests for clarity and full coverage of:
- Ace cards (A)
- Number cards (2–10)
- Face cards (J, Q, K)
- Invalid cards
Formatted the get-angle-type code using Prettier extension for consistent style.
Completed the second part of the Implement and Rewrite Test folder, including proper test coverage and organization.

Testing

All Jest tests pass locally, including the new edge case tests.

cjyuan

This exercise has a second part, where you are expected to implement Jest tests on the files in Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest.

Can you also include a Changelist section in the PR description?

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

cjyuan · 2026-03-09T13:40:30Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

  // TODO: Implement this function
+  if(numerator <= 0 || denominator <= 0){
+    return false;
+  }else if(numerator < denominator){


Can you check if 1/-2, -1/2, -1/-2 are consider proper fractions, and then update the implementation and tests accordingly?

Thank you for the suggestion — it was very useful. I checked 1/-2, -1/2, and -1/-2; all are proper fractions. I updated the isProperFraction function and tests using Math.abs() to handle these cases.

cjyuan · 2026-03-09T13:42:38Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  }else if(rank.match(/J|Q|K/)){
+    return 10;
+  }else if(rank.match(/^(10|[2-9])$/)){


Does your function return the value you expected from each of the following function calls?

getCardValue("0x02♠"); getCardValue("QQ♠"); getCardValue("2.1♠");

Thank you for pointing this out. I have tested the function with getCardValue("0x02♠"), getCardValue("QQ♠"), and getCardValue("2.1♠"); all now correctly throw an "Invalid card" error as expected. I also added Jest tests to cover these edge cases.

github-actions · 2026-03-10T10:50:04Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/1-implement-and-rewrite-tests/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2026-03-10T14:42:50Z

clear

What is this file?

cjyuan · 2026-03-10T15:01:02Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  if (rank === "A"){
+    return 11;
+  }else if(/^[JQK]$/.test(rank)){
+    return 10;
+  }else if(rank.match(/^(10|[2-9])$/)){
+    return Number(rank);
+  }else throw new Error("Invalid card");
+}


If you have successfully enabled "Format on save", and setup Prettier as your the default formatter in VSCode,
the formatter should have added a space between } and else, between if and (, and between ) and {.

If you have enabled "Format on save" but it is not working, it is likely that you haven't assign a formatter for JS file. This could happen if you have zero or multiple extensions that can format .js file.

If you have installed "Prettier" extension. To assign it as the formatter of JS code, you can try:

Use "Format document" to format the JS file. Sometimes, VSCode will ask you to choose a formatter, and you can manually select "Prettier".

Edit settings.json and set Prettier as the default formatter for JS.
See: https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

cjyuan · 2026-03-10T15:02:17Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test(`should return false when denominator is less than numerator`, () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+});
+test("should return false when numerator is zero", ()=>{
+  expect(isProperFraction(0, 1)).toEqual(false);
+});
+test("should return false when numerator is a negative number", ()=>{
+  expect(isProperFraction(-2, 2)).toEqual(false);
+});
+test("should return false when denominator is a negative number", ()=>{
+  expect(isProperFraction(2, -2)).toEqual(false);
+});
+test("should return false where both numerator and denominator are negative numbers", ()=> {
+  expect(isProperFraction(-3, -4)).toEqual(false);
+})


These descriptions are not quite accurate. Can you revise them?

Could consider testing all combination of positive and negative numerators and denominators.

It's ok to use symbols and notations in the description if they can help make the description more concise.

To learn by examples, use an AI tool to discover how you can phrase the test descriptions concisely.

Sprint 3: Implement functions and rewrite tests in Jest

f960b94

This comment has been minimized.

Sign in to view

RomanSanaye added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 1, 2026

RomanSanaye mentioned this pull request Mar 6, 2026

ITP-Jan | Structuring and testing data | Roman Sanaye RomanSanaye/My-Coursework-Planner#85

Open

cjyuan reviewed Mar 9, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 9, 2026

RomanSanaye added 4 commits March 10, 2026 09:59

Jest tests have been implemented

773ddc9

Get-angle-type codes have been formated

fc8717b

Implemented Jest test for tricky invalid cards

9d4539d

jest test implemented for tricky invalid cards

694f1cf

RomanSanaye added 2 commits March 10, 2026 11:03

isProperFraction is updated

10c6347

Merge branch 'main' into coursework/sprint-3-implement-and-rewrite

431a4ef

cjyuan reviewed Mar 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Implement functions and rewrite tests #1119

Birmingham | ITP-Jan | Ahmad Roman Sanaye | Sprint 3 | Implement functions and rewrite tests #1119
RomanSanaye wants to merge 7 commits intoCodeYourFuture:mainfrom
RomanSanaye:coursework/sprint-3-implement-and-rewrite

RomanSanaye commented Mar 1, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

cjyuan left a comment •

edited

Loading

Uh oh!

Uh oh!

cjyuan Mar 9, 2026

Uh oh!

RomanSanaye Mar 10, 2026

Uh oh!

cjyuan Mar 9, 2026

Uh oh!

RomanSanaye Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

cjyuan Mar 10, 2026

Uh oh!

cjyuan Mar 10, 2026

Uh oh!

cjyuan Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

RomanSanaye commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

This comment has been minimized.

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

RomanSanaye Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

RomanSanaye Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RomanSanaye commented Mar 1, 2026 •

edited

Loading

cjyuan left a comment •

edited

Loading