London | 26-ITP-January | Khaliun Baatarkhuu | Sprint 2 | Coursework. by khaliun-dev · Pull Request #1143 · CodeYourFuture/Module-Structuring-and-Testing-Data

khaliun-dev · 2026-03-03T08:58:13Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed all mandatory debugging exercises
Fixed logical errors in existing functions
Tested all exercises to confirm expected behavior

Questions

None at the moment.

Updated variable name to avoid redeclaration error.

Removed redeclaration of decimalNumber and updated console.log to call the function.

Corrected the square function to use a valid parameter name and return the square of the input.

…g the result. Changed console.log to return in multiply function to fix undefined error.

Corrected the sum function to return the sum of two numbers instead of undefined.

Updated the getLastDigit function to accept a parameter and removed unused variable.

Implement BMI calculation and log result.

Add function to convert string to upper snake case

…ock of code. Implemented the toPounds function to convert pence to pounds.

ykamal · 2026-03-03T14:04:56Z

Sprint-2/1-key-errors/0.js


-// =============> write your explanation here
-// =============> write your new code here
+//Above code works because we have used another variable "newStr", avoiding redeclaration.


This is good. But do you think there could be another way to do this? One that doesn't require you to declare any variables at all?

function capitalise(str) {
return str[0].toUpperCase() + str.slice(1);
}

Could this work? Just by removing the unnecessary variable?

Yes. Less memory, simpler. Well done

ykamal · 2026-03-03T14:07:03Z

Sprint-2/1-key-errors/1.js

-  const decimalNumber = 0.5;
  const percentage = `${decimalNumber * 100}%`;
-
  return percentage;


This is good. But do you think there could be another way to do this? One that doesn't require you to declare any variables at all?

function convertToPercentage(decimalNumber) {
return ${decimalNumber * 100}%;
}

console.log(convertToPercentage(0.5));

Yes similar to before

Make sure to retain the string templating

ykamal · 2026-03-03T14:10:01Z

Sprint-2/3-mandatory-implement/1-bmi.js


-function calculateBMI(weight, height) {
+ function calculateBMI(weight, height) {
+    const bmi = weight / (height * height);


There's a division here. Do you think we need to put in any specific safety guards?

We should guard against height being 0 so we could add the following guard:

if (height <= 0) {
return "Height must be greater than 0";
}

@ykamal I think i have fixed all three problems you have raised, could you please have another look?

Less than 0 is still fine. It's 0 that's the problem.

function calculateBMI(weight, height) {
if (height === 0) {
throw new Error("Height cannot be 0");
}

const bmi = weight / (height * height); return Number(bmi.toFixed(1));

}

@ykamal i have changed the guards for 0 specifically

Great, thanks. Ah, it's a body weight thing, so less than zero would be a problem 😂😂 but code wise this is fine

ykamal

After the division change, it should be good

ykamal

LGTM, approved

khaliun-dev · 2026-03-10T17:30:46Z

@ykamal thanks for approving my PR, could you add the completed tag, please?

ykamal · 2026-03-11T04:56:00Z

@ykamal thanks for approving my PR, could you add the completed tag, please?

Done. Hopefully I've done it right. Nice work

khaliun-dev added 10 commits February 23, 2026 18:44

Fixed redeclaration error in capitalise function

62dc90f

Updated variable name to avoid redeclaration error.

Fix redeclaration error and update console.log

1eea298

Removed redeclaration of decimalNumber and updated console.log to call the function.

Fix square function parameter and return statement

02c8367

Corrected the square function to use a valid parameter name and return the square of the input.

erased first console.log and replaced it with 'return' to properly lo…

a10df18

…g the result. Changed console.log to return in multiply function to fix undefined error.

Fixed the function to return the sum of 2 parameters properly

ad1ca7f

Corrected the sum function to return the sum of two numbers instead of undefined.

Fixed getLastDigit function

f9e4e19

Updated the getLastDigit function to accept a parameter and removed unused variable.

Add calculateBMI function to compute BMI

b7fb44c

Implement BMI calculation and log result.

Implement toUpperSnakeCase function

9c6d604

Add function to convert string to upper snake case

Added toPounds function for currency conversion to make a reusable bl…

4366cc4

…ock of code. Implemented the toPounds function to convert pence to pounds.

Refactor time formatting and add console logs

d46a3dd

khaliun-dev added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 3, 2026

ykamal reviewed Mar 3, 2026

View reviewed changes

kfklein15 requested a review from ykamal March 9, 2026 17:51

ykamal suggested changes Mar 10, 2026

View reviewed changes

ykamal approved these changes Mar 10, 2026

View reviewed changes

ykamal added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 10, 2026

ykamal added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 11, 2026

khaliun-dev mentioned this pull request Mar 11, 2026

London | 26-Jan-ITP | Structuring and testing data | Khaliun Baatarkhuu khaliun-dev/My-Coursework-Planner#21

Open

Uh oh!

Conversation

khaliun-dev commented Mar 3, 2026

Changelist

Questions

Uh oh!

ykamal Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ykamal left a comment

Choose a reason for hiding this comment

Uh oh!

ykamal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

khaliun-dev commented Mar 10, 2026

Uh oh!

ykamal commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ykamal Mar 3, 2026 •

edited

Loading

ykamal left a comment •

edited

Loading