Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Coursework#1217
Open
Seti-Jemal wants to merge 1 commit intoCodeYourFuture:mainfrom
Open
Sheffield | 26-ITP-Jan | Seti Mussa | Sprint 2 | Coursework#1217Seti-Jemal wants to merge 1 commit intoCodeYourFuture:mainfrom
Seti-Jemal wants to merge 1 commit intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Seti-Jemal
added
Needs Review
cjyuan
reviewed
Mar 11, 2026
Comment on lines
+23
to
+26
| function multiply(a,b){ | ||
| return a*b; | ||
| } | ||
| console.log(`The result of multiplying 10 and 32 is ${multiply(10, 32)} `); |
Contributor
There was a problem hiding this comment.
Indentation is off.
Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?
| // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase | ||
|
|
||
| function convertToUpperSnakeCase(str) { | ||
| return str.toUpperCase().trim().split("").join("_"); |
Contributor
There was a problem hiding this comment.
This works.
Could also consider using the string's methods .replaceAll() or replace().
Comment on lines
+8
to
+11
| function toPounds(kilograms) { | ||
| const pounds = kilograms * 2.20462; | ||
| return Number(pounds.toFixed(2)); | ||
| } |
Contributor
There was a problem hiding this comment.
In this exercise, the objective is to turn the "pence string to British pounds" code from an exercise in Sprint-1 into a function.
Can you update this implementation accordingly?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed sprint 2