Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
} else {
return 0;
}
}
return count;
}

module.exports = countChar;
3 changes: 3 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("should return '0' if character does not exist", () => {
expect(countChar("edak", "s")).toEqual(0);
});
16 changes: 15 additions & 1 deletion Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
function getOrdinalNumber(num) {
return "1st";
const numStr = num.toString();
const numLength = numStr.length;
if (numStr[numLength - 2] === "1" && numStr[numLength - 1] === "1") {
return num + "th";
} else if (numStr[numLength - 1] === "1") {
return num + "st";
} else if (numStr[numLength - 2] === "1" && numStr[numLength - 1] === "3") {
return num + "th";
} else if (numStr[numLength - 1] === "3") {
return num + "rd";
} else if (numStr[numLength - 1] === "2") {
return num + "nd";
} else {
return num + "th";
}
}
Comment on lines +2 to 17
Copy link

@Theoreoluwa Theoreoluwa Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a better arithmetic operator to be used for this function instead of string indexing. This ensures all edge cases are handled in your tests. To ensure code clarity and to avoid string manipulation


module.exports = getOrdinalNumber;
40 changes: 40 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,43 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

//case 2: Numbers ending with 11
test("should return 'th' for numbers ending with 11", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(111)).toEqual("111th");
expect(getOrdinalNumber(211)).toEqual("211th");
expect(getOrdinalNumber(1011)).toEqual("1011th");
});

//case:3 Numbers ending with 3 but not 13
test("Should return 'rd' for numbers ending with 3", () => {
expect(getOrdinalNumber(73)).toEqual("73rd");
expect(getOrdinalNumber(93)).toEqual("93rd");
expect(getOrdinalNumber(43)).toEqual("43rd");
expect(getOrdinalNumber(2003)).toEqual("2003rd");
});

//case:4 expect Numbers ending with 13 to return th
test(" should return 'th' for numbers ending with 13", () => {
expect(getOrdinalNumber(13)).toEqual("13th");
expect(getOrdinalNumber(413)).toEqual("413th");
expect(getOrdinalNumber(613)).toEqual("613th");
});
//case 4: expect number ending with 2 to return nd
test(" should return 'nd' for numbers ending with 2", () => {
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(42)).toEqual("42nd");
expect(getOrdinalNumber(102)).toEqual("102nd");
});

// case 5: expect number not included in the above case to return th
test("should return 'th' for numbers ending with 4, 5,6,7,8,9,0", () => {
expect(getOrdinalNumber(4)).toEqual("4th");
expect(getOrdinalNumber(5)).toEqual("5th");
expect(getOrdinalNumber(6)).toEqual("6th");
expect(getOrdinalNumber(7)).toEqual("7th");
expect(getOrdinalNumber(8)).toEqual("8th");
expect(getOrdinalNumber(9)).toEqual("9th");
expect(getOrdinalNumber(10)).toEqual("10th");
Comment on lines +50 to +59

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your tests are fine. But there might be one edge case you are missing out on. You handled 11 and 13; is there one more key group you might have missed?

});
10 changes: 8 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function repeatStr() {
return "hellohellohello";
function repeatStr(str, count) {
if (count >= 1) {
return str.repeat(count);
} else if (count === 0) {
return "";
} else {
throw new Error("Invalid count");
}
}

module.exports = repeatStr;
10 changes: 10 additions & 0 deletions Sprint-3/2-practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,23 @@ test("should repeat the string count times", () => {
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.
test("should return original string without repetition ", () => {
expect(repeatStr("edak", 1)).toEqual("edak");
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.
test("should return an 'empty string' for count value of 0", () => {
expect(repeatStr("edak", 0)).toEqual("");
});

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.

test("should throw and error if count value is negative integer", () => {
expect(() => repeatStr("edak", -1)).toThrow("Invalid count");
});
Loading