Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-implement-and-rewrite#1240
Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 3 | coursework/sprint-3-implement-and-rewrite#1240marthak1 wants to merge 7 commits intoCodeYourFuture:mainfrom
Conversation
marthak1
added
📅 Sprint 3
Edu-Vin
added
Review in progress
There was a problem hiding this comment.
I think you should check the definition of a proper fraction again and see if your test case for negative numbers is correct expecially -3/8. I will advise you to use Match.abs()
There was a problem hiding this comment.
Thanks for the feedback! My implementation checks whether the value of the fraction is between 0 and 1, which is the standard mathematical definition of a proper fraction. Based on that definition:
-3/8 → -0.375 → not proper
-8/-3 → 2.66… → not proper
-3/-8 → 0.375 → proper
Using Math.abs() would treat negative fractions like -3/8 as proper, even though their value is negative. That’s why I didn’t use Math.abs(), and why my tests reflect the “between 0 and 1” definition. Happy to adjust if a different definition is expected.
There was a problem hiding this comment.
The first rule of a proper fraction is that the numerator is less than the denominator. Your solution will fail on most negative numbers. Reason why a proper fraction is when the absolute value of the numerator is less than the absolute value of the denominator. A proper fraction is always less than 1
Based on your code, let's consider the following examples
you are returning properFraction > 0 && properFraction < 1
-1/2 will return false because the division is -0.5, and it is not greater than 0. But this is wrong as the result is less than 1 and the first rule of numerator < denominator stands.
Same thing with -3/8.
You can check this for further info https://www.splashlearn.com/math-vocabulary/proper-fraction
Math.abs() helps you work with negative numbers.
You can do more research on it.
There was a problem hiding this comment.
Thanks for explaining! I understand now that you're using the definition based on absolute values. I’ll update my code and tests to use Math.abs() so it matches that approach.
| test(`Should throw an error`, () => { | ||
| expect(() => { | ||
| getCardValue("♠9"); | ||
| }).toThrow(); |
There was a problem hiding this comment.
This is good. To take it further, add a test to see if the returned error message is what you are expecting.
There was a problem hiding this comment.
Thank you for the feedback . Would add further test to see what error messages they return.
Edu-Vin
added
Reviewed
|
Your recent commits added a solution for 2-practice-tdd. The Readme file for Sprint-3 says 1 pull request per directory, so 2-practice-tdd is supposed to have its own pull request. |
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
marthak1
force-pushed
the
coursework/sprint-3
branch
from
17cc045 to
06520c4
Compare
2 participants
Learners, PR Template
Self checklist
Changelist