Skip to content

London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Dead Code #1243

Closed
miriamjorna wants to merge 3 commits intoCodeYourFuture:mainfrom
miriamjorna:coursework/sprint-3-dead-code
Closed

London | 26-ITP-Jan | Miriam Jorna | Sprint 3 | Dead Code #1243
miriamjorna wants to merge 3 commits intoCodeYourFuture:mainfrom
miriamjorna:coursework/sprint-3-dead-code

Conversation

@miriamjorna
Copy link

@miriamjorna miriamjorna commented Mar 11, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Dead code exercises now in a PR in their own branch

NB I also have a directory ready for you with the 1+3 emails and the rejection reflection, plus proof of demos given and attended, and peer pair working.
Thanks for your time!

@miriamjorna miriamjorna added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Core This is a core task and should be completed by all trainees Module-Structuring-And-Testing-Data The name of the module. labels Mar 11, 2026
@Edu-Vin Edu-Vin added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Mar 11, 2026
@Edu-Vin
Copy link

Edu-Vin commented Mar 11, 2026

The dead code exercise was done, but you committed a folder, Spring-2, which is not needed in this pull request. Kindly remove it

@Edu-Vin Edu-Vin added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 11, 2026
@miriamjorna
Copy link
Author

miriamjorna commented Mar 12, 2026

Many thanks for your comment. I had put great effort in getting my directories in said Sprint-2 to behave - and clearly then did not check all the different branches in Sprint-3 for the same situation.
Done now!

@miriamjorna miriamjorna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@Edu-Vin
Copy link

Edu-Vin commented Mar 12, 2026

Well done! You did a good job with the task. There is still an issue; the pull request is supposed to only contain the sprint 3 folder. You can delete the Sprint-2 folder and push again

@Edu-Vin Edu-Vin removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
@miriamjorna
Copy link
Author

miriamjorna commented Mar 12, 2026 •
edited
Loading

Many thanks!
I pushed the cleaned up PR last night. Just to be sure I've pushed it again just now.
ETA:
Apologies, have just learnt that a listing of deleted files is not the same as the files not being there. Closing this PR and opening a new one is the cleanest solution.

@miriamjorna miriamjorna added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Core This is a core task and should be completed by all trainees Module-Structuring-And-Testing-Data The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miriamjorna @Edu-Vin @hoimir