NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 2 | jq #381
Open
ZabihollahNamazi wants to merge 2 commits into
Open
NW | 2026-mar-sdc | Zabihollah Namazi | Sprint 2 | jq #381ZabihollahNamazi wants to merge 2 commits into
ZabihollahNamazi wants to merge 2 commits into
Conversation
ZabihollahNamazi
added
📅 Sprint 2
cjyuan
reviewed
May 9, 2026
There was a problem hiding this comment.
Your solution works. You may want to check out these alternatives: https://github.com/CodeYourFuture/Module-Tools/tree/solutions/jq (especially the approach that uses string interpolation.)
| # The input for this script is the person.json file. | ||
| # TODO: Write a command to output the name of the person, then a comma, then their profession. | ||
| # Your output should be exactly the string "Selma, Software Engineer", but should not contain any quote characters. | ||
| jq -r '[.name, .profession] | join(", ")' person.json # join works on arrays thats why we need to to put values of name and profession in a array to be able to use join |
There was a problem hiding this comment.
Inline comments should be avoided in shell scripts unless they are very short, since separate-line comments are generally clearer and safer.
To further improve readability, consider also using empty line as separator to separate the spec and your solution.
Can you improve the readability of your scripts?
Author
There was a problem hiding this comment.
i have done what you suggested
thank you
cjyuan
added
Reviewed
ZabihollahNamazi
added
the
Needs Review
cjyuan
added
Complete
|
All good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
all are done and please review them , thanks