This repository was archived by the owner on Feb 9, 2024. It is now read-only.
London class 10-Junita Lama-react module-cyf hotel-week 1/2/3#586
Open
Junitalama wants to merge 32 commits intoCodeYourFuture:masterfrom
Open
London class 10-Junita Lama-react module-cyf hotel-week 1/2/3#586Junitalama wants to merge 32 commits intoCodeYourFuture:masterfrom
Junitalama wants to merge 32 commits intoCodeYourFuture:masterfrom
Conversation
Lauro235
reviewed
Jun 24, 2023
src/TouristInfoCards.js
Outdated
| import React from "react"; | ||
|
|
||
| const TouristInfoCard = () =>{ | ||
| return <div class="card"> |
There was a problem hiding this comment.
In React, we can convert all instances of 'class' to 'className'. Can you think why we can't use the word 'class' as an attribute?
Lauro235
reviewed
Jun 24, 2023
Lauro235
left a comment
Lauro235
left a comment
There was a problem hiding this comment.
Great work for week 1. 👍
I found it quite difficult to know what each commit was contributing to. It's helpful for reviewers to see from the commit description which portion of the exercise the commit relates to so maybe you could consider this for next week.
Well done again.
|
Kudos, SonarCloud Quality Gate passed!
|
Junitalama
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.