[feat][render preview][codecane] benchify integration #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
brandonkachen
force-pushed
the
brandon/benchify
branch
from
f095671 to
bd8e5eb
Compare
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
brandonkachen
force-pushed
the
brandon/benchify
branch
from
7cbf997 to
dfe75f1
Compare
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
…ration error handling; implement batch execution for deferred str_replace operations to improve reliability and observability. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
… validation and streaming integration Consolidates recent improvements to Benchify post-processing and batched str_replace execution. Reworks validateBenchifyResponse to use structural pattern match with clear business logic checks (no nested matches/continues), simplifies stream-parser integration, and expands tests for reliability. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…ENCHIFY_API_KEY. This replaces brittle spy usage and ensures resilience when Benchify is disabled. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
…rting getBenchifyClient for easier mocking; this prevents brittle failures when BENCHIFY_API_KEY is missing and stabilizes batch-str-replace tests. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
brandonkachen
force-pushed
the
brandon/benchify
branch
from
02ad02f to
b717bec
Compare
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
Co-authored-by: brandonkachen <brandonchenjiacheng@gmail.com> Co-authored-by: Codebuff <noreply@codebuff.com>
brandonkachen
changed the title
brandonkachen
temporarily deployed
to
brandon/benchify - web PR #312
Render
Destroyed
brandonkachen
temporarily deployed
to
brandon/benchify - backend PR #312
Render
Destroyed
brandonkachen
temporarily deployed
to
brandon/benchify - backend PR #312
Render
Destroyed
|
|
||
| const BENCHIFY_FILE_TYPES = ['tsx', 'ts', 'jsx', 'js'] | ||
| const BENCHIFY_TIMEOUT_MS = 3000 // 3 second timeout for Benchify calls | ||
| const BENCHIFY_MAX_FILES = 10 // Maximum files to send to Benchify |
There was a problem hiding this comment.
We actually could do quite a bit more than this potentially. For one of our app-builder customers we often get requests with 70+ files, and Juan's deploying blob support currently to make this quite a bit more network-efficient. So maybe worth revisiting.
| if (benchifyResult && benchifyResult.length > 0) { | ||
| logger.info( | ||
| { | ||
| benchifyResultCount: benchifyResult.length, |
There was a problem hiding this comment.
I don't think this makes sense to log. It's the length of a resolved string.
There was a problem hiding this comment.
I would think this was added previously when we were giving you ALL_FILES before we moved to DIFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.