Skip to content

[Term Entry] C++ Unordered-sets: bucket_size() #8127 #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dakshdeepHERE merged 10 commits into from
Jan 7, 2026
Merged

[Term Entry] C++ Unordered-sets: bucket_size() #8127 #8131

dakshdeepHERE merged 10 commits into from
Jan 7, 2026

Conversation

@Charles-Hardy
Copy link
Contributor

@Charles-Hardy Charles-Hardy commented Jan 2, 2026 •
edited by mamtawardhani
Loading

Description

  • Added a new entry for the term bucket_size() into Codecademy/docs/content/cpp/concepts/unordered-set/terms/bucket-size/bucket-size.md
  • Created to resolve issue number 8127

###Issue Solved
Closes #8042

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@Charles-Hardy Charles-Hardy mentioned this pull request Jan 2, 2026
Closed
9 tasks
@Charles-Hardy
Copy link
Contributor Author

Charles-Hardy commented Jan 2, 2026

I have raised this PR to supersede #8127 based on @mamtawardhani feedback

@Charles-Hardy Charles-Hardy mentioned this pull request Jan 2, 2026
Closed
3 tasks
@mamtawardhani mamtawardhani self-assigned this Jan 2, 2026
@mamtawardhani
Copy link
Collaborator

mamtawardhani commented Jan 2, 2026

Thank you! I'll review this @Charles-Hardy

@mamtawardhani
Revise bucket_size() documentation for unordered_set
360d8d3 
Updated the documentation for the bucket_size() method to reflect its use with unordered_set instead of unordered_map. Adjusted examples and descriptions accordingly.
mamtawardhani
mamtawardhani approved these changes Jan 5, 2026
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good for a second review! 🚀

@dakshdeepHERE dakshdeepHERE added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 7, 2026
@dakshdeepHERE dakshdeepHERE self-assigned this Jan 7, 2026
dakshdeepHERE
dakshdeepHERE approved these changes Jan 7, 2026
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a few minor changes here and there, looks good to merge.

@dakshdeepHERE dakshdeepHERE added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 7, 2026
dakshdeepHERE
dakshdeepHERE approved these changes Jan 7, 2026
View reviewed changes
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor updates to the entry and fixed the lint issue. @Charles-Hardy, make sure that when you create a PR, your branch name is related to the entry. For example, the branch name could have been bucketSize or CharlesBucketSize.

@dakshdeepHERE dakshdeepHERE merged commit 9d55956 into Codecademy:main Jan 7, 2026
7 checks passed
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

👋 @Charles-Hardy
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/unordered-set/bucket-size

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@dakshdeepHERE dakshdeepHERE dakshdeepHERE approved these changes

Assignees

@mamtawardhani mamtawardhani

@dakshdeepHERE dakshdeepHERE

Labels

c++ C++ entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Term Entry] C++ Unordered-sets: bucket_size()

3 participants

@Charles-Hardy @mamtawardhani @dakshdeepHERE