fix(Pagination): Previous and Next Buttons to respect RTL#3316
fix(Pagination): Previous and Next Buttons to respect RTL#3316LinKCoding merged 7 commits intocass-gmt-1601from
Conversation
|
View your CI Pipeline Execution ↗ for commit b73a384 ☁️ Nx Cloud last updated this comment at |
|
LinKCoding
force-pushed
the
kl-gmt-1592
branch
2 times, most recently
from
6ac1288 to
02e01c8
Compare
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
i'm seeing the arrows pointing inward for LTR
| useLayoutEffect(() => { | ||
| if (typeof document === 'undefined') return; | ||
| const doc = storyRef.current?.ownerDocument ?? document; | ||
| const root = doc.documentElement; | ||
| if (viewMode === 'story') { | ||
| root.setAttribute('dir', direction); | ||
| } else { | ||
| root.removeAttribute('dir'); | ||
| } | ||
| }, [direction, viewMode]); | ||
|
|
There was a problem hiding this comment.
were you having issues with the dir not updating?
There was a problem hiding this comment.
yea, but this seems resolved now, i.e. I deleted it and the story is updating without any issues.
I'll revert these additions, thanks for the check!
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
works great + thanks for the HiddenText update!
|
📬 Published Alpha Packages:
|
|
🚀 Styleguide deploy preview ready! Preview URL: https://69dd579533e1f92bfb9d3ce8--gamut-preview.netlify.app |
3 participants
Overview
Updates the Pagination component to use the correct Icon for Previous and Next that respect the
dirof the parent element.PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs