Skip to content

Added title to close button #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
girishpanchal30 wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Added title to close button #2728

girishpanchal30 wants to merge 1 commit into from
+3 −1

Conversation

@girishpanchal30
Copy link
Contributor

@girishpanchal30 girishpanchal30 commented Dec 26, 2025

Closes #2716

Summary

Added the missing title to the close button in pop-up.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 26, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 26, 2025
@girishpanchal30 girishpanchal30 mentioned this pull request Dec 26, 2025
Open
@girishpanchal30 girishpanchal30 linked an issue Dec 26, 2025 that may be closed by this pull request
Close button from the Popup block is missing a title #2716
Open
@girishpanchal30 girishpanchal30 changed the title fix: add title to close button Added title to close button Dec 26, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 26, 2025

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.38 KB 271.38 KB 0 B (0.00%)
Blocks 1.54 MB 1.54 MB 46 B (0.00%)
CSS 100.76 KB 100.76 KB 0 B (0.00%)
Dashboard 198.36 KB 198.36 KB 0 B (0.00%)
Onboarding 160.8 KB 160.8 KB 0 B (0.00%)
Export Import 97.73 KB 97.73 KB 0 B (0.00%)
Pro 407.08 KB 407.08 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 26, 2025

Plugin build for 1ee4aa5 is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Awaiting requested review from Soare-Robert-Daniel

Assignees

No one assigned

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Close button from the Popup block is missing a title

3 participants

@girishpanchal30 @pirate-bot