Skip to content

Fix nullable type declaration#1245

Merged
HardeepAsrani merged 1 commit intoCodeinwp:developmentfrom
todeveni:patch-1
Feb 25, 2026
Merged

Fix nullable type declaration#1245
HardeepAsrani merged 1 commit intoCodeinwp:developmentfrom
todeveni:patch-1

Conversation

@todeveni
Copy link
Contributor

@todeveni todeveni commented Feb 4, 2026

Summary

Fixes deprecation warnings on PHP 8.4.

Since Visualizer requires PHP 7.4 and nullable types are a PHP 7.1 feature, this shouldn't break any backwards compatibility.

Deprecated: Visualizer_Module_Chart::_getChartArray(): Implicitly marking parameter $chart as nullable is deprecated, the explicit nullable type must be used instead in /app/wp-content/plugins/visualizer/classes/Visualizer/Module/Chart.php on line 382

Will affect visual aspect of the product

NO

Test instructions

  • Load current plugin using a site with PHP 8.4
  • Watch deprecation errors/warnings on log

Check before Pull Request is ready:

@HardeepAsrani
Copy link
Member

Thank you for the contribution @todeveni

@HardeepAsrani HardeepAsrani changed the base branch from master to development February 25, 2026 18:36
@HardeepAsrani HardeepAsrani merged commit 1be891c into Codeinwp:development Feb 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants