Skip to content

Fix #235: [Model] NetworkReliability#725

Open
GiggleLiu wants to merge 6 commits intomainfrom
issue-235
Open

Fix #235: [Model] NetworkReliability#725
GiggleLiu wants to merge 6 commits intomainfrom
issue-235

Conversation

@GiggleLiu
Copy link
Contributor

Summary

Fixes #235

@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

❌ Patch coverage is 99.13043% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.62%. Comparing base (77577dd) to head (027a896).

Files with missing lines Patch % Lines
src/models/graph/network_reliability.rs 98.55% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main     #725    +/-   ##
========================================
  Coverage   97.61%   97.62%            
========================================
  Files         401      403     +2     
  Lines       49906    50136   +230     
========================================
+ Hits        48717    48944   +227     
- Misses       1189     1192     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GiggleLiu
Copy link
Contributor Author

Implementation Summary

Changes

  • Added NetworkReliability as a non-variant graph SatisfactionProblem in src/models/graph/network_reliability.rs, including exact reliability() / meets_threshold() helpers, schema metadata, canonical example-db wiring, and targeted unit tests.
  • Registered the model through src/models/graph/mod.rs, src/models/mod.rs, and src/lib.rs so it is discoverable through the catalog and prelude.
  • Added CLI creation support for pred create NetworkReliability with --failure-probs and --threshold, plus CLI tests for direct creation and canonical-example creation.
  • Documented the model in docs/paper/reductions.typ, added supporting bibliography entries in docs/paper/references.bib, and aligned the paper/example regression test with the exact issue example value 0.96842547 > 0.95.

Deviations from Plan

  • Task boundaries collapsed into a single implementation pass, but the architecture stayed the same.
  • The standard solver API was intentionally left unchanged; exact reliability threshold evaluation lives in model-local helpers rather than a new solver trait.

Open Questions

  • None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Model] NetworkReliability

1 participant