refactor: finish generalized aggregation migration#754
Merged
Conversation
- Inline string literals in eprintln! format strings (print_literal) - Use saturating_sub instead of manual arithmetic check - Merge identical if-else branches in add_ilp_solver_hint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…lem-reductions into jg/aggregation
Adapt ConsecutiveOnesMatrixAugmentation, PartialFeedbackEdgeSet, and GroupingBySwapping (merged from main) to the new Problem trait: - type Metric -> type Value - SatisfactionProblem -> WitnessProblem - Remove unused Solver imports from tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
==========================================
- Coverage 97.65% 97.50% -0.16%
==========================================
Files 455 455
Lines 55706 56680 +974
==========================================
+ Hits 54401 55265 +864
- Misses 1305 1415 +110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…riptions Replace legacy Valid(...)/Invalid display strings with direct aggregate wrapper names (Max, Min, Or, Sum). Update export_module_graph.rs to reflect the new trait hierarchy. Add doc comment on EdgeCapabilities default. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add tests for: - SolveViaReductionError Display/Error impls - ILPSolver::solve_dyn, supports_direct_dyn, try_solve_via_reduction - solve_via_reduction with nonexistent problem - format_metric direct usage - LoadedDynProblem backward-compat solve and Debug - AggregateReductionChain single-step path rejection - Aggregate chain with witness-only edge returns None Re-export SolveViaReductionError from ilp module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Three CLI tests still asserted stdout.contains("Valid") after the
aggregate formatting change. Update to match the new Max(...) output.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Test job was running without --workspace, which could miss CLI integration test failures that the Coverage job (which uses --workspace) would catch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
isPANN
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Max/Min/Extremumvalues and remove the staleSolutionSize/DirectionsurfaceTest Plan