fix(medcat-trainer): Remove kwargs from modelpack.save as they error#305
Closed
alhendrickson wants to merge 1 commit intomainfrom
Closed
fix(medcat-trainer): Remove kwargs from modelpack.save as they error#305alhendrickson wants to merge 1 commit intomainfrom
alhendrickson wants to merge 1 commit intomainfrom
Conversation
Member
|
@alhendrickson this still WIP? |
Collaborator
Author
|
Yeah it's a todo - I'll create the ticket 869c1h5qh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The args/kwargs cause the save function to error out. I didnt test it before assuming they were probably just empty... but anyway this reverts #300