Skip to content

fix(medcat-trainer): Remove kwargs from modelpack.save as they error#305

Closed
alhendrickson wants to merge 1 commit intomainfrom
fix/trainer/load_examples
Closed

fix(medcat-trainer): Remove kwargs from modelpack.save as they error#305
alhendrickson wants to merge 1 commit intomainfrom
fix/trainer/load_examples

Conversation

@alhendrickson
Copy link
Collaborator

The args/kwargs cause the save function to error out. I didnt test it before assuming they were probably just empty... but anyway this reverts #300

[medcattrainer]   File "/home/api/api/models.py", line 140, in save
[medcattrainer]     super().save(*args, update_fields=['concept_db', 'vocab'], **kwargs)
[medcattrainer]   File "/usr/local/lib/python3.11/site-packages/django/db/models/base.py", line 852, in save
[medcattrainer]     raise ValueError("Cannot force both insert and updating in model saving.")
[medcattrainer] ValueError: Cannot force both insert and updating in model saving.

@alhendrickson alhendrickson marked this pull request as ready for review January 21, 2026 12:29
@alhendrickson alhendrickson marked this pull request as draft January 21, 2026 12:40
@tomolopolis
Copy link
Member

@alhendrickson this still WIP?

@alhendrickson
Copy link
Collaborator Author

alhendrickson commented Feb 5, 2026

Yeah it's a todo - I'll create the ticket

869c1h5qh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants