Skip to content

[DiscordRPC] Fix non-functioning global toggle #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bagusnl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DiscordRPC] Fix non-functioning global toggle #849

bagusnl wants to merge 2 commits into from

Conversation

@bagusnl
Copy link
Member

@bagusnl bagusnl commented Dec 29, 2025

Main Goal

Fix global RPC toggle not actually disabling RPC.
Also disable RPC regional setting when global toggle is set to disabled.

Closes #806

PR Status :

  • Overall Status : Done
  • Commits : Done
  • Synced to base (Collapse:main) : Yes
  • Build status : OK
  • Crashing : No
  • Bug found caused by PR : 0

Templates

Changelog Prefixes 
  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

@bagusnl
[DiscordRPC] Fix toggle not actually disabling RPC
0da50fc 
Signed-off-by: Bagus Nur Listiyono <dzakibagus@gmail.com>
@bagusnl
[DiscordRPC] Disable regional QS toggle if global toggle is off
47086d0 
Signed-off-by: Bagus Nur Listiyono <dzakibagus@gmail.com>
@bagusnl bagusnl requested a review from a team December 29, 2025 18:28
@bagusnl bagusnl self-assigned this Dec 29, 2025
@bagusnl bagusnl added Bug Something isn't working Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse Priority: Medium Size: Small labels Dec 29, 2025
@bagusnl
Copy link
Member Author

bagusnl commented Dec 30, 2025

@sentry review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bagusnl bagusnl

Labels

Area: Runtime Issue labeled for runtime, Hi3Helper.Core and other libraries used by Collapse Bug Something isn't working Priority: Medium Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: trying to connect discord rpc even disable all discord features

2 participants

@bagusnl