Conversation
| }), | ||
| dts({ | ||
| tsconfig: './tsconfig.lib.json' | ||
| tsconfig: './tsconfig.src.json' |
There was a problem hiding this comment.
This seems to work just as well, so I removed the lib config
| "emitDeclarationOnly": true, | ||
| "erasableSyntaxOnly": true, | ||
| "exactOptionalPropertyTypes": true, | ||
| "forceConsistentCasingInFileNames": true, |
There was a problem hiding this comment.
Is this true by default?
There was a problem hiding this comment.
Yes it is.
From npx tsc --all:
--forceConsistentCasingInFileNames Ensure that casing is correct in imports.
type: boolean
default: true
| "module": "esnext", | ||
| "lib": [], | ||
| "moduleDetection": "force", | ||
| "moduleResolution": "bundler", |
There was a problem hiding this comment.
| "moduleResolution": "bundler", |
This is the default, no?
There was a problem hiding this comment.
--moduleResolution Specify how TypeScript looks up a file from a given module specifier.
one of: node16, nodenext, bundler
default: `nodenext` if `module` is `nodenext`; `node16` if `module` is `node16` or `node18`; otherwise, `bundler`.
It should be, but with conditions. Maybe best to enforce it?
| @@ -1,26 +1,19 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "allowSyntheticDefaultImports": true, | |||
There was a problem hiding this comment.
It's enabled by default
I tried disabling it and it logged
tsconfig.js.json:3:3 - error TS5107: Option 'allowSyntheticDefaultImports=false' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.
There was a problem hiding this comment.
It does not log a deprecation warning if it's explicitly set to true 🤔
| }, | ||
| "include": ["website/**/*"], | ||
| "include": ["src/css.d.ts", "website/**/*"], | ||
| "references": [{ "path": "tsconfig.src.json" }] |
There was a problem hiding this comment.
Does references not pull css.d.ts?
There was a problem hiding this comment.
No.
When using composite projects, references are loaded from compiled type definitions, not source files, and css.d.ts/globals.d.ts are not preserved.
Which is probably better, so global types/overrides are not automatically reused, especially so we don't pollute other projects when they import react-data-grid.
You can check the output in .cache/ts/src if you want to double-check.
2 participants
Jira: no ticket
Description
The stable version will be released next week, but we can adopt it earlier.