Skip to content

Remove todesktop staging config#1540

Merged
benceruleanlu merged 2 commits intomainfrom
chore/remove-todesktop-staging
Mar 4, 2026
Merged

Remove todesktop staging config#1540
benceruleanlu merged 2 commits intomainfrom
chore/remove-todesktop-staging

Conversation

@benceruleanlu
Copy link
Copy Markdown
Member

@benceruleanlu benceruleanlu commented Jan 16, 2026

We don't use the todesktop staging platform anymore, so this is out of date, but maybe we should instead update this later for if we do start to use staging again.

Summary

  • remove the publish:staging script
  • delete the unused todesktop.staging.json config

┆Issue is synchronized with this Notion page by Unito

Summary by CodeRabbit

Chores

  • Removed staging environment build script and configuration, streamlining the deployment infrastructure.

@benceruleanlu benceruleanlu requested a review from a team as a code owner January 16, 2026 22:55
Copilot AI review requested due to automatic review settings January 16, 2026 22:55
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

The pull request removes staging-specific build configuration: the publish:staging npm script is deleted from package.json, and the todesktop.staging.json configuration file is removed.

Changes

Cohort / File(s) Summary
Staging config & scripts
package.json, todesktop.staging.json
Deleted the publish:staging npm script from package.json. Removed todesktop.staging.json, a staging-specific ToDesktop config that extended the base config and contained staging metadata and package details.

Poem

I hopped through code with nimble paws,
Removed a file without a pause.
No staging scripts to chase the moon,
The build now sings one tidy tune.
🐇✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the main change: removing the todesktop staging configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-todesktop-staging

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the staging environment configuration for ToDesktop builds. The PR cleans up unused staging-related configuration by deleting the staging config file and removing the associated npm script.

Changes:

  • Removed todesktop.staging.json configuration file
  • Deleted the publish:staging npm script from package.json

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
todesktop.staging.json Removed entire staging configuration file that extended the main todesktop.json with staging-specific settings
package.json Removed publish:staging script that referenced the deleted staging config

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@comfy-pr-bot
Copy link
Copy Markdown
Member

Test Evidence Check

⚠️ Warning: Test Explanation Missing

If this PR modifies behavior that requires testing, a test explanation is required. PRs lacking applicable test explanations may not be reviewed until added. Please add test explanations to ensure code quality and prevent regressions.

⚠️ Warning: Visual Documentation Missing

If this PR changes user-facing behavior, visual proof (screen recording or screenshot) is required. PRs without applicable visual documentation may not be reviewed until provided.

You can add it by:

  • GitHub: Drag & drop media directly into the PR description
  • YouTube: Include a link to a short demo

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2026
@benceruleanlu benceruleanlu merged commit e4c927a into main Mar 4, 2026
12 checks passed
@benceruleanlu benceruleanlu deleted the chore/remove-todesktop-staging branch March 4, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants