Skip to content

fix: remove CardGroup/Columns wrapping external Card links to fix double-tab bug#1105

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix/cardgroup-double-link
Jun 5, 2026
Merged

fix: remove CardGroup/Columns wrapping external Card links to fix double-tab bug#1105
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix/cardgroup-double-link

Conversation

@lin-bot23
Copy link
Copy Markdown
Contributor

Problem

Clicking a Card with an external href inside CardGroup or Columns opens two browser tabs instead of one. This is a Mintlify framework-level bug in how these wrapper components handle event propagation for external links.

Root Cause

Mintlify's CardGroup and Columns components trigger duplicate navigation events for Cards with external href values. Internal links (relative paths like /tutorials/...) are not affected.

Fix

All external-link Cards previously wrapped in CardGroup or Columns are now rendered as standalone Cards (vertically stacked). Internal-link Cards inside groups are preserved.

Scope

  • 137 files modified across all three locales (EN, ZH, JA)
  • Exceptions: lens.mdx files - the CardGroup containing external links is entirely comment-blocked (/* ... */), so it was left untouched.

Testing

Verified on local Mintlify dev preview:

  • Standalone Cards -> single tab (OK)
  • Columns-wrapped external Cards -> double tab (framework bug confirmed)
  • Internal-link Cards in groups -> single tab (OK, unchanged)

@lin-bot23 lin-bot23 force-pushed the fix/cardgroup-double-link branch 2 times, most recently from 47cd185 to 578ce4e Compare June 5, 2026 12:29
@comfyui-wiki comfyui-wiki merged commit 079df2a into Comfy-Org:main Jun 5, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants