RFC: security policy - disallow requests or similar for code downloads in modules#12
Open
teward wants to merge 2 commits intoComfy-Org:mainfrom
Open
RFC: security policy - disallow requests or similar for code downloads in modules#12teward wants to merge 2 commits intoComfy-Org:mainfrom
requests or similar for code downloads in modules#12teward wants to merge 2 commits intoComfy-Org:mainfrom
Conversation
Add RFC0005 to RFCs
teward
changed the title
requests or similar for code downloads in modules
|
The discussion thread link points back to the PR by mistake. I created a discussion thread for this RFC here: |
…o rfcs/0005-security-policy-disallow-requests-for-code-downloads.md
huchenlei
changed the title
requests or similar for code downloads in modulesrequests or similar for code downloads in modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add RFC0005 to RFCs
Summary
Updates the Registry policies to prohibit separate downloading of Python code for 'inclusion' in a module's dependencies.
Links
Full Rendered Proposal
Discussion Thread
Comfy-Org/docs PR that adds this to the Policy: Comfy-Org/docs#50
Third party repository doing unsafe behaviors, hence the writing of this policy: https://github.com/1038lab/ComfyUI-OmniGen/blob/4f9d6a945e3fa7aaf4485c4e7c5292c9b4826ab7/ailab_OmniGen.py
Third party repository issue regarding unsafe behavior: 1038lab/ComfyUI-OmniGen#38
Important: Do NOT comment on this PR. Please use the discussion thread linked above to provide feedback, as it provides branched discussions that are easier to follow. This also makes the edit history of the PR clearer.