Conversation
|
Hi! I wanted to use your code, but I found a small issue with your PR: you forgot to remove the (There are also a number of dependencies that are not indicated in Thanks for making the PR! |
|
fyi I already did something similar at https://github.com/rom1504/taming-transformers and released it to pypi at https://pypi.org/project/taming-transformers-rom1504/ if the authors want to maintain their pypi package, I'd gladly PR that though! |
1b89947 to
fefe15a
Compare
|
@Evarin Good catch -- fixed all this stuff. Thanks! I have also added a simple GitHub actions check that makes sure the package is importable after @rromb @pesser I think this is ready to review/merge now! I think you might need to click a button to get GitHub actions to run. It passes on my fork: https://github.com/bfirsh/taming-transformers/runs/3738638366 |
| import numpy as np | ||
| from omegaconf import OmegaConf | ||
| from PIL import Image | ||
| from main import instantiate_from_config, DataModuleFromConfig |
There was a problem hiding this comment.
DataModuleFromConfig is unused in the scripts.
|
I have rebased this and fixed conflicts. @rromb @pesser @manolo-lolo does this look good? :) |
This pull request makes it possible to do:
I have done this by:
find_namespace_packages()instead offind_packages()so setuptools can find packages without__init__.pyinstantiate_from_configinside thetamingpackage so it is importableref #62 #30