lint: disable yamllint line-length check#14793
Open
vojtapolasek wants to merge 1 commit into
Open
Conversation
this check is extremely hard to enforce in this repo, we push yaml to its borders with various HTML tags, Jinja macros etc
vojtapolasek
added
Infrastructure
|
@vojtapolasek: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
Jun 11, 2026
Mab879
left a comment
Mab879
left a comment
Member
There was a problem hiding this comment.
Approving. Leaving this open for others to leave feedback.
| * Have a total path length less than 250 characters | ||
| * Shall not use "smart quotes" or curved quotes | ||
| * Maximum line length should be 99 characters | ||
| * Maximum line length of 99 characters is preferred but not enforced. |
Member
There was a problem hiding this comment.
This change is fine, but I might come back and do pass to make style guide wording follows RFC 2119 to make this clear for everything else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
line-lengthcheck and update the developer style guide to reflect that the 99-character limit is preferred but not enforced.Rationale:
Review Hints:
.yamllint(config change) anddocs/manual/developer/04_style_guide.md(documentation update).