Azure App Configuration / Feature Flags#1244
Open
Ryan-Palmer wants to merge 2 commits intoCompositionalIT:masterfrom
Open
Azure App Configuration / Feature Flags#1244Ryan-Palmer wants to merge 2 commits intoCompositionalIT:masterfrom
Ryan-Palmer wants to merge 2 commits intoCompositionalIT:masterfrom
Conversation
5 tasks
ninjarobot
requested changes
Apr 20, 2026
Collaborator
ninjarobot
left a comment
There was a problem hiding this comment.
Thanks for contributing this @Ryan-Palmer. I made a few requests for adjustments.
| let enabled = this.State |> string |> _.ToLower() | ||
|
|
||
| let featureFlagValue = | ||
| $"""{{"id":"{this.Name}","description":"{this.Description}","enabled":{enabled}}}""" |
Collaborator
There was a problem hiding this comment.
This is freeform text, so it will need JSON escaping. One quick way would be like:
[
"id", box this.Name
"description", this.Description
"enabled", enabled
] |> dict |> System.Text.Json.JsonSerializer.Serialize| type ConfigurationStoreBuilder() = | ||
| member _.Yield _ = { | ||
| Name = ResourceName.Empty | ||
| Location = Location.NorthEurope |
Collaborator
There was a problem hiding this comment.
This shouldn't be in the builder - it will get set on the resulting resource in the BuildResources call.
|
|
||
| /// Disables local authentication for the configuration store. | ||
| [<CustomOperation "disable_local_auth">] | ||
| member _.DisableLocalAuth(state: ConfigurationStoreConfig, disable: bool) = { |
Collaborator
There was a problem hiding this comment.
Since this member is called "disable_local_auth", it doesn't need the boolean argument and should just set DisableLocalAuth to true when the operation is called.
|
|
||
| /// Sets the location of the configuration store. | ||
| [<CustomOperation "location">] | ||
| member _.Location(state: ConfigurationStoreConfig, location) = { state with Location = location } |
Collaborator
There was a problem hiding this comment.
Can also remove this location operation since this is set automatically with by BuildResources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #387
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
I'll update docs and tests once the general implementation has been given the thumbs up.
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: